Buttercup-desktop: Improve trash usability

[alireza-ahmadi]

I think Trash group needs a couple of changes:

• Prevent users from creating a new entry in Trash group
• Allow users to empty Trash group(Maybe using a right click menu following by a confirmation dialog)

If you agree, I can send a pull request for these features in the next few days.

[sallar]

@alireza-ahmadi Thanks! These are valid concerns. And the PR is certainly most welcome.

[alireza-ahmadi]

Great 👍, I will start working on it as soon as possible.

[perry-mitchell]

Please be aware that this should be implemented in parallel in the core. It's not enough that the interface protects against it, it should be blocked at the functionality level.

[perry-mitchell]

This shouldn't be closed until it's also implemented in the core.

[alireza-ahmadi]

@perry-mitchell Thanks, I will try to implement the functionality in the buttercup-core too.

[perry-mitchell]

I could also implement it, was just mentioning that they should go together 🙂

[alireza-ahmadi]

@perry-mitchell If you are okay I prefer to implement core functionality as well. I like to read most of the application source code and implementing this feature can be a good excuse for that. I will let you know if there was any problem in the implementation process.

[sallar]

@alireza-ahmadi Are you still doing this?

[perry-mitchell]

This is already in progress in the core (I started it recently), so perhaps this should be blocked until that part is done (buttercup-pw/buttercup-core#121)

EDIT: However this UI behavioural part is still free, of course. Please let us know @alireza-ahmadi if you're available to do this.

[sallar]

Another friend was also interested in doing this (the UI part). Thats why Im asking

[perry-mitchell]

The core part (buttercup-pw/buttercup-core#121) is now complete and in production as v0.31.0.

First come first served on the PR 😄

EDIT: Of course the empty-trash functionality is still pending in core: buttercup-pw/buttercup-core#131

[perry-mitchell]

So i've released buttercup-pw/buttercup-core#131 (Trash emptying) as 0.32.0: https://github.com/buttercup-pw/buttercup-core/blob/master/CHANGELOG.md#v0320

~This is not yet in the core-web package so it can't be used here just yet, but this UI functionality can be added without waiting.~
Core-web is now at 0.16.0 and includes the trash improvements.

[sallar]

@perry-mitchell thanks!
@alireza-ahmadi I gave this a go, since you haven't updated the status, so Im assuming I can do this. It'll be merged soon. Thanks!