Build: Need support for running pbr test with Dart2JS

[matanlurey]

I think something isn't setup right yet, it only works for DDC.

[jakemac53]

hmm we have a basic e2e test to verify this works, what issues are you seeing?

[matanlurey]

Unable to find a _browser_test file. Let me try and get a repro!

[matanlurey]

[INFO] CreateOutputDir: Creating merged output dir `/var/folders/bn/dtrksvvs32j6004mk6r0dcdw007b7h/T/build_runner_testW0WjDj/` completed, took 1.3s
[INFO] CreateOutputDir: Writing asset manifest completed, took 1ms
[INFO] Build: Succeeded after 28.0s with 526 outputs
Running tests...

00:00 +0: compiling test/di/tree_bindings_reflective_test.dart
00:00 +0 -1: compiling test/di/tree_bindings_directive_test.dart [E]
  Failed to load "test/di/tree_bindings_directive_test.dart": Failed to load script at http://localhost:53765/CaTnFWBkXLE0NT7j1gj3omj0O2ycOVq3/test/di/tree_bindings_directive_test.dart.browser_test.dart.js.
00:00 +0 -2: compiling test/di/20_bindings_reflective_test.dart [E]
  Failed to load "test/di/20_bindings_reflective_test.dart": Failed to load script at http://localhost:53765/CaTnFWBkXLE0NT7j1gj3omj0O2ycOVq3/test/di/20_bindings_reflective_test.dart.browser_test.dart.js.
00:00 +0 -3: compiling test/di/20_bindings_directive_test.dart [E]
  Failed to load "test/di/20_bindings_directive_test.dart": Failed to load script at http://localhost:53765/CaTnFWBkXLE0NT7j1gj3omj0O2ycOVq3/test/di/20_bindings_directive_test.dart.browser_test.dart.js.
00:00 +0 -4: compiling test/di/tree_bindings_reflective_test.dart [E]
  Failed to load "test/di/tree_bindings_reflective_test.dart": Failed to load script at http://localhost:53765/CaTnFWBkXLE0NT7j1gj3omj0O2ycOVq3/test/di/tree_bindings_reflective_test.dart.browser_test.dart.js.
00:00 +0 -5: compiling test/bootstrap_test.dart [E]
  Failed to load "test/bootstrap_test.dart": Failed to load script at http://localhost:53765/CaTnFWBkXLE0NT7j1gj3omj0O2ycOVq3/test/bootstrap_test.dart.browser_test.dart.js.
00:00 +0 -5: Some tests failed.

[jakemac53]

Can I see your build.yaml?

[matanlurey]

NO (Yes).

targets:
  $default:
    builders:
      build_web_compilers|entrypoint:
        generate_for:
        - web/**.dart
        options:
          compiler: dart2js
          dart2js_args:
          - --fast-startup
          - --minify
          - --trust-type-annotations
          - --trust-primitives

[jakemac53]

And if you swap to dartdevc it works?

[jakemac53]

Oh wait, I think you just need a - test/**.dart addition to generate_for?

[matanlurey]

Good question.

I wonder if this is a similar problem as one of my earlier bugs, where it kills the default configuration (including test bootstrapping) by having custom configuration.

[matanlurey]

Oh wait, I think you just need a - test/**.dart addition to generate_for?

DOH. Let me try that.

[matanlurey]

... and that worked. I'm a silly. Anything we should document here?

[jakemac53]

Not sure if there is anything easy we could do in terms of an error message here - we could search for _test.dart files and make sure there is a .dart.browser_test.dart.js file but that seems like overkill... wdyt?

[jakemac53]

this only comes up if you have custom build.yaml config, but I think because we don't have defaults around the js compiler today that might be more common than we would want.

[matanlurey]

That's true. Let's close this for now, thanks!