Build: Add a way of overriding the config for a builder globally
Right now you can only do it per target, but you can imagine plenty of scenarios where a global override would be what you want. For instance switching the dev compiler builder from analyzer mode to kernel mode.
We also want this for the command line flags so we will need the general plumbing regardless I think.
jakemac53
All 7 comments
What should the config approach be other than command line args? Something in build.yaml?
natebosch
on 5 Jan 2018
I think it should be something in build.yaml, because people will want to have it be something they can save as a permanent setting as well as overriding on the command line. To that end I would also expect the command line args to take precedence.
jakemac53
on 5 Jan 2018
We should also probably make the target level config override the global config? I am actually not 100% sure on that though.
jakemac53
on 5 Jan 2018
As discussed offline:
We also need to explore how this might interact with the --config flag, and whether we should be honoring that flag for build.<config>.yaml files from dependencies. For instance if we want to put together a release and debug mode set of options for build_web_compilers - how can we expose that?
natebosch
on 29 Jan 2018
This is coming up again for the module granularity.
We want to push to see if we can avoid it but we're still considering it.
natebosch
on 18 Apr 2018
@natebosch this is done now right?
jakemac53
on 15 Jun 2018
Yes, fixed by https://github.com/dart-lang/build/pull/1561
natebosch
on 15 Jun 2018
Related issues
kentcb
路
7Comments
yury-yufimov
路
6Comments
carlowenig
路
3Comments
DJafari
路
4Comments
simolus3
路
4Comments
Most helpful comment
As discussed offline:
We also need to explore how this might interact with the
--configflag, and whether we should be honoring that flag forbuild.<config>.yamlfiles from dependencies. For instance if we want to put together areleaseanddebugmode set of options forbuild_web_compilers- how can we expose that?