Browser-laptop: Fix Cross-Origin Read Blocking (CORB) for extensions

[srirambv]

Description

Lastpass login page not shown on clean profile

Test plan / Steps to Reproduce

1. Install 0.23.72
2. Enable Lastpass from extension
3. Click on extension icon, shows Internet error unable to connect
4. Close extension popup, console logs error
   [7544:8104:0725/114251.439:ERROR:extension_function_dispatcher.cc(585)] Unknown Extension API - tabs.getAllInWindow
5. Click extension popup again shows load spinner but nothing opens

Actual result:

Expected result:
Extension should load

Reproduces how often:
100% on new profile
Reproduced on mac by @LaurenWags

Brave Version

about:brave info:

Brave|
--|--0.23.72
V8|6.8.275.24
rev|c3b1cac
Muon|8.0.2
OS Release|10.0.17134
Update Channel|Release
OS Architecture|x64
OS Platform|Microsoft Windows
Node.js|7.9.0
Brave Sync|v1.4.2
libchromiumcontent|68.0.3440.75

Reproducible on current live release:
No

Additional Information

When lastpass is enabled on Beta and then enabled on release channel it shows correct login popup page. Issue happens only when trying on release channel

[bsclifton]

Per @darkdh

https://developer.chrome.com/extensions/tabs#method-getAllInWindow
the API has been deprecated

@jonathansampson has updated the LastPass extension to 4.15.2.5 which should resolve the issue 😄 👍 It may take a while for the change to get picked up on existing installs. Please re-open if you're not seeing the new version 😄

[darkdh]

No, the API issue has been there for a long time and it is a easy fix.
However, the real problem is some changes related to CrossOriginReadBlocking that causes

newserver.js:1 
Cross-Origin Read Blocking (CORB) blocked cross-origin response https://lastpass.com/lmiapi/login/type?username= with MIME type application/json. See https://www.chromestatus.com/feature/5629709824032768 for more details.

[darkdh]

CORB error fixed by https://github.com/brave/muon/pull/618/commits/3c654ffc3ae1b3ce689c306d2b0c8d90f3d7bdc2
API error fixed by https://github.com/brave/muon/pull/618/commits/4cd780d6ec7991d0d0132010a783aef5e3be9de7

will be available in muon 8.0.3

[btlechowski]

Verified on Ubuntu 17.10 x64

• 0.23.73 50bdb6df42550dd14f5636770ec8585aa26e361b
• Muon 8.0.3
• libchromiumcontent 68.0.3440.75

Verified on Windows x64 with

• 0.23.73 50bdb6df42550dd14f5636770ec8585aa26e361b
• Muon 8.0.3
• libchromiumcontent 68.0.3440.75

[bsclifton]

Re-opening as issue may have been re-introduced. @darkdh can address this soon with a new Muon

[darkdh]

These two commits were left over when merging C68 into master

[kjozwiak]

Received several +1's from the community:

• #15109
• https://reddit.com/r/brave_browser/comments/9b2z6d/v023104_for_desktop_has_been_released
• https://community.brave.com/t/lastpass-is-unable-to-connect-to-servers-persistent-error-messages-displayed/

[darkdh]

fixed in muon 8.0.9

[srirambv]

Verified on Windows 10 x64 using

• 0.23.105 9a46f8f
• Muon 8.0.9
• libchromiumcontent 68.0.3440.84
• Verified no errors when opening the extension popup
• Verified able to login to Lastpass account
• Verified able to autofill credential details
• Verified background page doesn't throw any error when using the password manager to autofill

Passed with macOS 10.12.6 using

• 0.23.105 9a46f8f
• Muon 8.0.9
• libchromiumcontent 68.0.3440.84
• verified STR
• Verified no errors when opening the extension popup
• Verified able to login to Lastpass account
• Verified able to autofill credential details
• Verified background page doesn't throw any error when using the password manager to autofill

PASSed on Ubuntu 17.10 x64

• 0.23.105 9a46f8f
• Muon 8.0.9
• libchromiumcontent 68.0.3440.84

[stellar6]

FIXED: tested on Win 10 x64

Brave: 0.23.105
V8: 6.8.275.24
rev: 9a46f8f5cb22a9daf2af21989aed25911aa6f839
Muon: 8.0.9

Verified no errors when opening the extension popup
Verified able to login to Lastpass account

[kjozwiak]

@stellar6 thanks for double checking! Really appreciate it! 👍

[NumDeP]

@kjozwiak this was posted an hour ago mentioning an issue still persists with generating and fill and add new pass on MacOS - https://community.brave.com/t/lastpass-still-not-working/31111