Browser-laptop: entire div for 'What do these policies mean?' is clickable

Created on 8 May 2018  路  6Comments  路  Source: brave/browser-laptop

Description

On about:preferences#security there is a link below the WebRTC setting for 'What do these policies mean?' Only the link should be clickable, but the entire div is clickable.

Steps to Reproduce

  1. Navigate to about:preferences#security
  2. Hover over 'What do these policies mean?' div and click anywhere on the div
  3. WebRTC wiki page is opened.

Actual result:
Entire div is clickable

Expected result:
Only the link should be clickable.

Reproduces how often:
easily

Brave Version

about:brave info:
0.22.703

Reproducible on current live release:
n/a

Additional Information

Similar to https://github.com/brave/browser-laptop/issues/12137

0.22.x Qchecked-Linux Qchecked-Win64 Qchecked-macOS bugood-first-bug help wanted polish prioritP5 release-noteinclude

Most helpful comment

Hi there @thelostone-mc

  • you are correct; no tests available and none required
  • gif capturing it is great!
  • I can help you with the review! 馃槃 馃憤

All 6 comments

@bsclifton should we move this into 0.23.x? I know we were moving issues out of 0.23.x during the triage call but we already have #12137 fixed which is similar. Might as well fix all these cases if we can. Should be a trivial fix as well. Thoughts?

@kjozwiak since it's such a small one, I think we can skip on including it with 0.23.x. However, this would be a great first bug for somebody (and we can pull into 0.23.x if it's done sooner than later)

Here's a picture showing the issue; the entire div is clickable, rather than using a span (or inline-blocking it, etc)
screen shot 2018-05-08 at 4 40 22 pm

Hey first time contributor here!

Had a few questions :

  • Since this is a html tag change -> I believe there aren't tests which I can write up for this
  • I added a gif to show the difference
  • Whom do I reach out to add labels for my PR to state it's ready for review ? (cause I don't have permissions)

Hi there @thelostone-mc

  • you are correct; no tests available and none required
  • gif capturing it is great!
  • I can help you with the review! 馃槃 馃憤

Verified on Windows 10 x64

  • 0.23.11 6565c0689f8bfbd6f4d03e2e8c68c9381da157f6
  • Muon 7.1.0
  • libchromiumcontent 67.0.3396.87

Verified on macOS 10.13.4 x64 using the following build:

  • 0.23.11 6565c0689f8bfbd6f4d03e2e8c68c9381da157f6
  • muon: 7.1.0
  • libchromiumcontent: 67.0.3396.87

Verified on Ubuntu 17.10 x64

  • 0.23.11 - 6565c06
  • Muon - 7.1.0
  • libchromiumcontent - 67.0.3396.87
Was this page helpful?
0 / 5 - 0 ratings

Related issues

bsclifton picture bsclifton  路  3Comments

briannyeko picture briannyeko  路  3Comments

jonathansampson picture jonathansampson  路  3Comments

luixxiul picture luixxiul  路  3Comments

bbondy picture bbondy  路  3Comments