Browser-laptop: Bug -- Ctrl+f search bar not functional

Created on 26 Mar 2018 · 11Comments · Source: brave/browser-laptop

Description

CTRL+F search pops up the search bar however it is not functional.

Steps to Reproduce

CTRL+F
Use search term
No search prompted
-->
Actual result:

searchplease

Expected result:
SEARCH TERM: "Please" for example does not work.

Reproduces how often:

What percentage of the time does it reproduce?
---Intermittent

Brave Version

about:brave info:

Please open about:brave, copy the version information, and paste it.

Reproducible on current live release:

Qchecked-Linux Qchecked-Win64 Qchecked-macOS Qtest-plan-specified bug featurfindbar needs-info release-noteexclude

Source

ryanmusante

All 11 comments

Thanks for reporting.

Can you update your Brave to 0.21.24 and recheck?

btlechowski on 26 Mar 2018

brave-snapshot-bin 0.21.24-1 in AUR. I will update tonight and check and re-post details.

ryanmusante on 27 Mar 2018

I am _unable_ to reproduce from my build:

Brave: 0.21.24 
V8: 6.5.254.36 
rev: 19c78a1624118e344852c4c0f44c0d45be841b5f 
Muon: 4.9.3 
OS Release: 10.0.16299 
Update Channel: Release 
OS Architecture: x64 
OS Platform: Microsoft Windows 
Node.js: 7.9.0 
Brave Sync: v1.4.2 
libchromiumcontent: 65.0.3325.162

jonathansampson on 27 Mar 2018

I couldn't reproduce the issue under Ubuntu 17.10.1 x64 using the latest BETA:

Brave: 0.22.7 
V8: 6.5.254.41 
rev: 8bb7e77f69bca186429aafda4bc6ba4d82a5de47 
Muon: 5.1.1 
OS Release: 4.13.0-36-generic 
Update Channel: Beta 
OS Architecture: x64 
OS Platform: Linux 
Node.js: 7.9.0 
Brave Sync: v1.4.2 
libchromiumcontent: 65.0.3325.181

@ryanmusante could you share some more information with us? Which website are you visiting where you're seeing this happen?

kjozwiak on 27 Mar 2018

👍1

Bug seemed only present for sites using forum softwares: PHPBB / Discourse.
It is working without problems with beta.

ryanmusante on 28 Mar 2018

@ryanmusante, could it be possible that the data at the bottom still hasn't been loaded/rendered, hence the search functionality not finding it? If you have the entire page/thread loaded and searching isn't working, that's definitely still an issue that we'll need to fix.

kjozwiak on 3 Apr 2018

@kjozwiak I'm still testing with the latest git branch and it seems to be working good now. I'll keep posted on any changes

ryanmusante on 13 Apr 2018

👍1

Awesome! Thanks @ryanmusante, much appreciated!

kjozwiak on 13 Apr 2018

@ryanmusante is this still happening on our latest build?