Browser-laptop: Constant nag popup asking "Ready to support your favorite sites?"
Test Plan
https://github.com/brave/browser-laptop/pull/13465
Description
Brave browser displays unwanted nag screen, repeatedly.
Text: "Hello! Ready to support your favorite sites? Brave will fill your wallet with tokens to get you started!"
The only options are "maybe later" or "I'm ready". The "NO!" option is missing.
Steps to Reproduce
- Open Brave browser.
- Be annoyed.
Actual result:
Expected result:
Reproduces how often:
Seems to occur every day on every installation of Brave.
Brave Version
about:brave info:
Brave: 0.19.139
rev: 99aa17da28e040543b4ba217d2c4dd6633bf1446
Muon: 4.7.2
libchromiumcontent: 64.0.3282.85
V8: 6.4.388.20
Node.js: 7.9.0
Update Channel: Release
OS Platform: Microsoft Windows
OS Release: 10.0.16299
OS Architecture: x64
Reproducible on current live release:
Yes.
Additional Information
basildane
All 22 comments
I don't seem to have this issue.
BraveSupporter
on 21 Jan 2018
Interesting, I have Brave installed on 6 computers at home and work, and it does this on all six of them.
basildane
on 21 Jan 2018
cc: @bradleyrichter
bsclifton
on 22 Jan 2018
@NejcZdovc Can you post the current logic here so we can examine and adjust it accordingly?
bradleyrichter
on 22 Jan 2018
as far as I can tell from the notification this is triggered when we add promotion. We added disable option in 0.20 https://github.com/brave/browser-laptop/issues/12313
NejcZdovc
on 22 Jan 2018
12313 is only for BAT promotions. General Brave Payments invitations are separate.
Those originally had a time restriction before first appearance. And a longer delay before appearance 2.
I would like to use "no thanks" for the deny button on the second attempt which would disable further notifications until the user would opt-in to BP.
bradleyrichter
on 22 Jan 2018
yeah but if you check out initial issue Brave will fill your wallet with tokens to get you started! it's about BAT promotion
NejcZdovc
on 22 Jan 2018
Ah...yes. You are right. This mixed alert will be handled by the new switch for BAT offers.
bradleyrichter
on 22 Jan 2018
srirambv
on 26 Jan 2018
My only options are "Maybe Later" and "I'm Ready". I've clicked "Maybe Later" at least a dozen times since installing beta 0.20.22 a day or two ago.
How can we make this stop?
dfwdraco76
on 28 Jan 2018
Can I make a suggestion to the devs? Rather than code ways to stop this message, you need to rethink some things. As in: don't do this in the first place. These types of messages are nothing but a nuisance and this type of behavior is what has driven the community away from other applications and websites. If someone wants to do something, they will. If they don't, then no amount of nagging is going to change that. It's simply going to make them leave, which I'm sure is not your intention.
basildane
on 29 Jan 2018
I would normally agree ^ but the current alert approach is working for UGP grant acceptance. We will improve Brave Payments awareness through better marketing and a better onboarding for new users. At that point we can reevaluate removal of nag alerts.
To solve this nag for the majority, this is what we need to do:
Show the first time at 10 days of browsing.
If answer is “maybe later”, then show again at 30 days.
On this 2nd nag, the button changes from “maybe later” to “no thanks” and never nags again.
@NejcZdovc please reference this issue in the PR for this fix...
bradleyrichter
on 9 Feb 2018
Moving back to 0.22.x for now (since there isn't already a PR for this)
bsclifton
on 13 Feb 2018
@NejcZdovc @bradleyrichter confused on this one - per https://github.com/brave/browser-laptop/issues/12758#issuecomment-364570120 I get the sense (but it's not explicitly stated) that the 'No Thanks' button should not be displayed on the first appearance of this notification. However, per the test plan in https://github.com/brave/browser-laptop/pull/13465 I am seeing this 'No Thanks' button on the first appearance of the notification. Can one of you please clarify - should 'No Thanks' be displayed the first time or not?
LaurenWags
on 22 Mar 2018
second question @nejczdovc and @bradleyrichter - should the 'No Thanks' also be on this notification:
LaurenWags
on 22 Mar 2018
@LaurenWags it should be on all promotion notifications
NejcZdovc
on 22 Mar 2018
@LaurenWags yes we should display it for the first time as well
NejcZdovc
on 22 Mar 2018
so then 'Maybe Later' does not change to 'No Thanks', correct? @nejczdovc
LaurenWags
on 22 Mar 2018
maybe later will show notification again in 24h, where no thanks will disable promotions @LaurenWags
NejcZdovc
on 22 Mar 2018
yes @LaurenWags - we didn't correctly update the test case.
We decided to reduce NAG pain by giving the user more control on the first notice.
Eventually the suggested choice on the far right will be an orange button as well.
bradleyrichter
on 23 Mar 2018
Thanks for the confirmations @nejczdovc and @bradleyrichter!
LaurenWags
on 23 Mar 2018
Verified on macOS 10.12.6 x64 using the following build:
- 0.22.7 https://github.com/brave/browser-laptop/commit/8bb7e77f69bca186429aafda4bc6ba4d82a5de47
- libchromiumcontent: 65.0.3325.181
- muon: 5.1.1
Verified on Windows 7 x64
- 0.22.7 8bb7e77f
- libchromiumcontent: 65.0.3325.181
- muon: 5.1.1
Went through verification on Ubuntu 17.10.1 x64 using the following build:
0.22.78bb7e77- libchromiumcontent:
65.0.3325.181 - muon:
5.1.1
LaurenWags
on 23 Mar 2018
Related issues
luixxiul
·
3Comments
shortstuffsushi
·
3Comments
luixxiul
·
3Comments
jonathansampson
·
3Comments
bbondy
·
3Comments
Most helpful comment
Can I make a suggestion to the devs? Rather than code ways to stop this message, you need to rethink some things. As in: don't do this in the first place. These types of messages are nothing but a nuisance and this type of behavior is what has driven the community away from other applications and websites. If someone wants to do something, they will. If they don't, then no amount of nagging is going to change that. It's simply going to make them leave, which I'm sure is not your intention.