Browser-laptop: Incorrect decimal values shown for BAT-USD after reconcile

[srirambv]

Description

Incorrect decimal values shown for BAT-USD after reconcile

Test plan / Steps to Reproduce

1. Fund wallet with decimal values such as 7.51 BAT
2. Change reconcilestamp to trigger payment process
3. Once reconcile is complete, shows incorrect decimal values for BAT-USD

Actual result:

Expected result:
Should show correct BAT-USD values even for decimal values

Reproduces how often:
100%

Brave Version

about:brave info:

Brave | 0.19.136
-- | --
rev | 1659471
Muon | 4.7.1
libchromiumcontent | 64.0.3282.85
V8 | 6.4.388.20
Node.js | 7.9.0
Update Channel | Release
OS Platform | Microsoft Windows
OS Release | 10.0.16299
OS Architecture | x64

Reproducible on current live release:
Yes

Additional Information

Found the scenario on staging wallet.
browser profile
cc: @mrose17 @evq @bsclifton

[NejcZdovc]

@bradleyrichter what should we display here? USD value is 0.0066051665 and we only show two places and because of rounding we are currently displaying 0.01 USD which is of course wrong

[NejcZdovc]

This line is problematic https://github.com/brave/browser-laptop/blob/master/app/browser/api/ledger.js#L1614

[mrose17]

how about <.01USD ?

[bradleyrichter]

This should work!

On Jan 16, 2018, at 5:32 AM, Marshall T. Rose [e-mail] wrote:

how about <.01USD ?

—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub, or mute the thread.

[LaurenWags]

Showing <.01 USD on MacOS:

[bradleyrichter]

@NejcZdovc I think it would look better to add a leading 0.

So, 0.01 BAT (< 0.01 USD)

[LaurenWags]

And a space between the < and the leading zero as in your example @bradleyrichter ? Meaning:
0.01 BAT (< 0.01 USD) vs 0.01 BAT (<0.01 USD)

[NejcZdovc]

Reopening, so that we can adjust this value

[srirambv]

Looks good on Windows

[LaurenWags]

MacOS:

[kjozwiak]

Looks good under Ubuntu 17.10 x64 👍 Used 0.21.16 a7bed47f55863b9f48e5ce31bcaf8c6ee21c10d5 without any issues.