Browser-laptop: Disable auto-include publisher causes existing publishers to be excluded

Created on 12 Jan 2018  路  5Comments  路  Source: brave/browser-laptop

Test plan

https://github.com/brave/browser-laptop/pull/12624

Description

Disable auto-include publisher causes existing publishers to be excluded

Steps to Reproduce

  1. Clean install 0.19.133
  2. Enable payments, visit some publishers to add entry in ledger table
  3. Disable auto-include, visit a new site, all entries gets disabled

Actual result:
On 0.19.133
ledgeryt
On 0.19.131
ledgeryt-131

Expected result:
Should not exclude all existing publishers form the table

Reproduces how often:
100%

Brave Version

about:brave info:

Brave | 0.19.131 | 0.19.133
-- | -- | --
rev | da2f347 | e05a8ef
Muon | 4.5.36| 4.5.38
libchromiumcontent | 63.0.3239.132 | 63.0.3239.132
V8 | 6.3.292.49| 6.3.292.49
Node.js | 7.9.0 | 7.9.0
Update Channel | Release | Release
OS Platform | Microsoft Windows | Microsoft Windows
OS Release | 10.0.16299 | 10.0.16299
OS Architecture | x64 | x64

Reproducible on current live release:
No

Additional Information

Same behaviour on 0.20.x as well
cc: @NejcZdovc @bridiver @bsclifton

Qchecked-Linux Qchecked-Win64 Qchecked-macOS Qtest-plan-specified bug featurrewards release-noteinclude

Most helpful comment

I still thing that we need to fix it soon, could be quite a problem, so I will add it into 0.20.x

All 5 comments

This regressed with muon upgrade from .36 to .38

Same issue on Linux as well
ledger-linux

But with a different(new) profile it wasn't reproduced. Although it did have other publishers listed
image

ok this is not a new thing it's just timing thing

I still thing that we need to fix it soon, could be quite a problem, so I will add it into 0.20.x

Reproduced on MacOS with 0.19.133

Was this page helpful?
0 / 5 - 0 ratings

Related issues

luixxiul picture luixxiul  路  3Comments

antiroyalty picture antiroyalty  路  3Comments

lukemulks picture lukemulks  路  3Comments

eljuno picture eljuno  路  3Comments

jonathansampson picture jonathansampson  路  3Comments