Browser-laptop: Feature Request: Keyboard Shortcut for toggling Bookmarks Toolbar

[jonathansampson]

Description

The user should be able to toggle Bookmarks Toolbar visibility with Ctrl+Shift+B.

Steps to Reproduce

1. Press Ctrl+Shift+B

Actual result:
Nothing

Expected result:
Bookmarks Bar toggles

Reproduces how often:
100%

Brave Version

0.19.131

Additional Information

Related to #5212

[jbyte]

Hello, I would like to do this one.

[jonathansampson]

@jbyte That would be awesome! Let us know if you have any questions about cloning or setting-up.

[jbyte]

The cloning and setup went fine from what I can tell (brave launches normally).

The only question I have is regarding the Brave version. In the issue contents it is stated that this relates to the 0.19.131 version. So should I create my feature branch from the 0.19.x branch or is master ok?

[bsclifton]

@jbyte it would be great if you could create a branch based on master 😄 The issue was reported with 0.19.131, but it does affect all versions

As for where to make the change, you might check out this file 😄
https://github.com/brave/browser-laptop/blob/da42f04860e14ae4925499a01cb2bcf37436b1b3/app/common/commonMenu.js#L289

You should be able to add an accelerator with the proposed key stroke to bookmarksToolbarMenuItem

[jbyte]

@bsclifton Thank you for the hint :D.

[btlechowski]

Verified on Ubuntu 17.10 x64

• 0.23.8 06c657bb7ee5530f93c37f51cc6b7bf158912d04
• Muon 6.1.5
• libchromiumcontent 66.0.3359.181

Verified on Windows 10 x64

• 0.23.8 06c657bb7ee5530f93c37f51cc6b7bf158912d04
• Muon 6.1.5
• libchromiumcontent 66.0.3359.181

Verified on macOS 10.13.4 x64 using the following build:

• 0.23.11 6565c0689f8bfbd6f4d03e2e8c68c9381da157f6
• muon: 7.1.0
• libchromiumcontent: 67.0.3396.87