Browser-laptop: Formatting for Saved Site Exceptions (deleted YT channels) should match ledger table

Created on 13 Dec 2017  路  7Comments  路  Source: brave/browser-laptop

Test Plan

See STR.
Also need to check ledger entries which were deleted in previous versions of Brave.

Description

After deleting a YT channel from your ledger table, if you go to re-add it under Shields > Saved Site Exceptions > Brave Payments, the YouTube channel is listed, the formatting doesn't match how the payments screen displays it.

Steps to Reproduce

  1. Visit a YT channel for min time so it displays in your ledger table
  2. Click the trash can icon to remove from ledger table
  3. Navigate to Preferences > Payments > Show Deleted sites

Actual result:
Formatting for site name doesn't display the way it does on ledger:
screen shot 2017-12-13 at 8 55 57 am

Expected result:
Formatting should match ledger for readability and in case user had accidentally removes one.

Reproduces how often:
Easily

Brave Version

about:brave info:
Brave | 0.19.115
rev | 584e694
Muon | 4.5.25

Reproducible on current live release:
yes

Additional Information

Similar to https://github.com/brave/browser-laptop/issues/12217

Qchecked-Linux Qchecked-Win64 Qchecked-macOS Qtest-plan-specified bug featurrewards prioritP5 release-noteexclude

Most helpful comment

Just did some more testing and with the latest code that we have for 0.22 we can't preform upgrade for this case anymore, because we don't have information about the name. So this scenario is expected.

All 7 comments

do you think that we need to update old (existing) entries as well or only new ones?

@NejcZdovc I think it would be great if we could update the existing entries. WDYT @kjozwiak @srirambv @bsclifton ?

Agreed would be good to have the existing entries updated.

image
Verified on Windows x64

  • 0.22.702 e4a853d
  • libchromiumcontent 66.0.3359.139
  • muon: 6.0.7

Verified with macOS 10.12.6 using

Verified on Ubuntu 17.10 x64

  • 0.22.703 903b8d0d
  • libchromiumcontent 66.0.3359.139
  • muon: 6.0.8

@NejcZdovc if a YouTube or Twitch site was deleted in 0.22.669 and you update to 0.22.702, it displays as below. While this is more read-able than previously, it doesn't match what happens if you delete a site using 0.22.702 (see screenshot from https://github.com/brave/browser-laptop/issues/12271#issuecomment-386386054 ). Expected?
screen shot 2018-05-03 at 5 15 12 pm

@LaurenWags we set version value a long time ago and it was set to trigger upgrade if version is smaller then 0.22.3. We can adjust this value to 0.22.7.

Just did some more testing and with the latest code that we have for 0.22 we can't preform upgrade for this case anymore, because we don't have information about the name. So this scenario is expected.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

jonathansampson picture jonathansampson  路  3Comments

jonathansampson picture jonathansampson  路  3Comments

luixxiul picture luixxiul  路  3Comments

jonathansampson picture jonathansampson  路  3Comments

luixxiul picture luixxiul  路  3Comments