When long YT entries are added into the ledger, both the "Pin" and "Delete" buttons won't align correctly and will appear on two separate lines. This makes it very difficult to click on either the "Pin" or "Delete" buttons for websites that are in the middle of the ledger... It takes a few seconds to make sure you're correctly clicking on the correct button... This is definitely a usability regression and makes the ledger a lot harder to use/manage.
Actual result:
Both the "Pin" & "Delete" buttons are not being aligned and are being displayed on separate lines
Expected result:
Both the "Pin" & "Delete" buttons should be correctly aligned and appear in a single line
Reproduces how often:
100% reproducible using the above STR
about:brave info:
Brave: 0.19.93
rev: 25085d0b5a0a6cf8a740cac8b246ebf1a97146f7
Muon: 4.5.16
libchromiumcontent: 62.0.3202.94
Reproducible on current live release:
Nope, the YT feature isn't present within 0.19.88
Related Bug: https://github.com/brave/browser-laptop/issues/11960
@srirambv checked Russian and the ledger table looks great:
We should make sure that English looks like the above table as it's probably the main language being used right now...
Fixed with https://github.com/brave/browser-laptop/commit/22c2aee81d11fb2ddb77cc237c3953632ffe2e39
@luixxiul can you help me confirm that this is NOT needed on 0.20, 0.21, and master? I manually tested and I believe the change is only needed for 0.19.x
If you could not reproduce the issue on those branches, I assume refactoring works on sortableTable have taken care of it.
Most helpful comment
If you could not reproduce the issue on those branches, I assume refactoring works on sortableTable have taken care of it.