Browser-laptop: Clicking on any entry in the kebab menu results in TypeError

[evq]

• Did you search for similar issues before submitting this one?
  Yes
• Describe the issue you encountered:
  Clicking on any entry in the kebab menu results in a TypeError, and clicks to switch tabs, etc stop working.
• Platform (Win7, 8, 10? macOS? Linux distro?):
  Archlinux AppVM on Qubes, i3 WM
• Brave Version (revision SHA):
  master (4042f5f)

• Steps to reproduce:

  1. Click on "settings" in the kebab menu

• Actual result:
  Browser stops responding to most clicks, the following error is seen in the dev console:

Uncaught TypeError: Cannot read property 'filter' of undefined
    at ContextMenuSingle.render (contextMenu.js:236)
    at ReactCompositeComponent.js?d2b3:795
    at measureLifeCyclePerf (ReactCompositeComponent.js?d2b3:75)
    at ReactCompositeComponentWrapper._renderValidatedComponentWithoutOwnerOrContext (ReactCompositeComponent.js?d2b3:794)
    at ReactCompositeComponentWrapper._renderValidatedComponent (ReactCompositeComponent.js?d2b3:821)
    at ReactCompositeComponentWrapper._updateRenderedComponent (ReactCompositeComponent.js?d2b3:745)
    at ReactCompositeComponentWrapper._performComponentUpdate (ReactCompositeComponent.js?d2b3:723)
    at ReactCompositeComponentWrapper.updateComponent (ReactCompositeComponent.js?d2b3:644)
    at ReactCompositeComponentWrapper.receiveComponent (ReactCompositeComponent.js?d2b3:546)
    at Object.receiveComponent (ReactReconciler.js?399b:124)

• Expected result:
  Browser should navigate to the preferences page
• Will the steps above reproduce in a fresh profile? If not what other info can be added?
  Yes
• Is this an issue in the currently released version?
  Unk
• Can this issue be consistently reproduced?
  Yes

[dorin131]

I am experiencing the same issue and have a fix. Can I make a pull request?

[evq]

@dorin131 Please do. I have a work-around (just adding a check / returning null) however a root cause fix would be great.

[dorin131]

@evq That was going to be my fix :D
But let me try to figure out the root cause and do it properly.

Also, several tests are failing. Is it OK to skip them when pushing this fix and deal with them as a separate issue?

[bsclifton]

@dorin131 if unit tests are failing, I can help you look at it (as part of the pull request) 😄

[dorin131]

@bsclifton this doesn't seem to be an issue anymore

[evq]

Can confirm that this appears to have been fixed.