Browser-laptop: History inside autocomplete suggestions cannot be cleared until the browser is closed

[luixxiul]

Test plan

https://github.com/brave/browser-laptop/pull/10795#issue-255310957

---

Describe the issue you encountered: History inside autocomplete suggestions cannot be cleared until the browser is closed.

• Platform (Win7, 8, 10? macOS? Linux distro?): Debian

• Brave Version (revision SHA): 0.17.10

• Steps to reproduce:

  1. Clear the browser's profile
  2. Go to :g brave
  3. Clear the data via Clear browsing data inside History
  4. Enter brave to the URL bar

• Actual result:

  

• Expected result: the history should be cleared before you restart the browser

• Extra QA steps:
  1.
  2.
  3.

• Any related issues:

[bsclifton]

cc: @bbondy who was in this code recently (w/ bloodhound improvements)

[bsclifton]

Is this a dupe of https://github.com/brave/browser-laptop/issues/9715?

[luixxiul]

I don't think so as you get the error without enabling Sync.

[bsclifton]

@luixxiul sync enabled not needed- see @diracdeltas comment:

I see the same bug on a fresh profile without sync enabled. If you click 'delete history entry', the history entry just gets added back at the bottom of the list.

[srirambv]

+2 from community https://community.brave.com/t/anyone-have-random-history-entries-that-still-come-up-even-with-all-history-deleted/4594/

[bsclifton]

+1 from user @patrick99e99 (reported with https://github.com/brave/browser-laptop/issues/9884)

[cndouglas]

This seems separate but related to #8761/#9715.

[cndouglas]

+1 from me (#10421)

[cndouglas]

Regression of #5147

[bsclifton]

@Liunkae I don't think it's a regression- it was never fixed. https://github.com/brave/browser-laptop/issues/5147 was closed as stale

[hackobi]

I have the same problem but when I quit and relaunch the URL addresses are still there.