Browser-laptop: Hiding menu shows empty white space

[sorin-davidoi]

Test plan

1. Launch Brave on Linux (under Gnome)
2. Press ALT to toggle the menu
3. the menu should show and hide, leaving no white space behind

Original issue description

• Did you search for similar issues before submitting this one?

Yes

• Describe the issue you encountered:

Hiding the menu by pressing the alt key shows an empty space instead of hiding it.

• Platform (Win7, 8, 10? macOS? Linux distro?):

ArchLinux

• Brave Version (revision SHA):

0.15.301 (4e86cab)

• Steps to reproduce:

  1. Press Alt to hide the menu bar

• Actual result:

The menu bar is hidden, but an empty white container is shown instead.

• Expected result:

The menu bar is hidden, saving vertical space.

• Will the steps above reproduce in a fresh profile? If not what other info can be added?

Yes.

• Is this an issue in the currently released version?

Yes.

• Can this issue be consistently reproduced?

Yes.

• Screenshot if needed:
  

[luixxiul]

I remember I noticed that kind of white space on Debian.

[sorin-davidoi]

I think it was introduced with 0.15.3 (did not noticed it with 0.15.2).

[admshao]

I have the same problem on Archlinux, 0.15.2 was fine

[bsclifton]

I think this problem is related to the changes I recently made in Muon with https://github.com/brave/muon/commit/5012b72485fbed0f4693bf9eb74c6d0ca40fb054

Linux has an open issue (captured in https://github.com/brave/browser-laptop/issues/5086) which I believe is the root cause for this

[sorin-davidoi]

Also noticed that the menu / white container does not disappear when a video is full-screen.

[admshao]

It does appear for me while in Video fullscreen.
GNOME Shell 3.24.2 / XServer 1.19.3

[bsclifton]

Looking into this now...

[bsclifton]

Found the root cause and fixed 😄