Browser-laptop: Extension: MetaMask

Created on 4 May 2017  路  7Comments  路  Source: brave/browser-laptop

QA steps here!!!

https://github.com/brave/browser-laptop/pull/11534


Extension: MetaMask

image

For development purposes, the background page for this extension can be accessed by navigating to the following URL: chrome-extension://dkjoiblfkdpnahoolgkbmgihdfkflnkm/_generated_background_page.html

Needed APIs:

chrome.browserAction

  • [x] #5367 chrome.browserAction.setBadgeBackgroundColor (docs)
  • [x] #5366 chrome.browserAction.setBadgeText (docs)

chrome.extension

  • [x] #8688 chrome.extension.getURL (docs, _deprecated_)

chrome.runtime

  • [x] #8682 chrome.runtime.connect (docs)
  • [x] #8683 chrome.runtime.getManifest (docs)
  • [x] #8684 chrome.runtime.onConnect.addListener (docs)
  • [x] #8685 chrome.runtime.onInstalled.addListener (docs)(https://github.com/brave/muon/pull/344)
  • [x] ~#8686 chrome.runtime.reload (docs)~

chrome.tabs

  • [x] #8680 chrome.tabs.create (docs)

chrome.windows

  • [x] #6789 chrome.windows.create (docs)(https://github.com/brave/muon/pull/295)
  • [x] #8677 chrome.windows.getAll (docs)
  • [x] #8678 chrome.windows.remove (docs)
  • [x] #8679 chrome.windows.update (docs)
Qchecked-Linux Qchecked-Win32 Qchecked-Win64 Qchecked-macOS Qtest-plan-specified featurextensions prioritP5 project-tracking release-noteinclude

Most helpful comment

nothing blocks Metamask now :wink:

All 7 comments

@Snapshot of working/non-working functionality as of this morning:

Window loads when fox icon clicked: Yes
Accepting Terms works:              Yes
Saving secret words works:          Yes
Main account page displayed:        Yes
Switching networks:                 Yes
Switch accounts page displays:      Yes
Hamburger menu displays:            Yes
Create additional account:          Yes
Etherscan Link:                     Yes
Buy from Coinbase, full flow        Yes
Close window button after CB buy    No
"Continue to Coinbase"              Yes, No if switched back from Shapeshift (bug?)
Buy:                                Yes (checked w/ Coinbase)
Send:                               Yes (checked w/ Coinbase)
Coinbase confirmed:                 Yes
Badge:                              Yes, seemed to work for me
Website integration:                Yes* (*no window appears, must click)
Web window appears automatically:   No
Website integration, full flow:     Yes (for both successes and failures)

@kevinlawler we merged your changes with https://github.com/brave/browser-laptop/pull/9647; is there anything needed before we close this issue? It looks like some of the items above are still marked as open... but they may be optional or just referenced this issue. I am thinking this can be closed?

@bsclifton leave this issue open. we use these to track the remaining incompatibilities

@kevinlawler OK sounds great! I'll remove milestone

Any news on Metamask extension ?

nothing blocks Metamask now :wink:

Closing since this is included.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

lukemulks picture lukemulks  路  3Comments

bbondy picture bbondy  路  3Comments

jonathansampson picture jonathansampson  路  3Comments

eljuno picture eljuno  路  3Comments

octohedron picture octohedron  路  3Comments