Browser-laptop: Convert React ContextMenu items to native context menu

Created on 3 May 2017  路  5Comments  路  Source: brave/browser-laptop

This issue is meant to track places which use our React component which we can convert to using native context menus. This works great on Windows and Linux, but macOS causes video to freeze when the context menu is presented. The above PR makes that process async

Places we can update:

  • [x] new tab button (completed with https://github.com/brave/browser-laptop/pull/8397)
  • [x] reload / stop button (has reload / clean reload, #9571)
  • [ ] menubar on Windows (we should be able to do this now, since the PR above is macOS only)
    ... TODO: document other places...

Places we can consider updating (which have moderate difficulty):

Places which we shouldn't change (requires a lot of extra work to do natively):

cc: @Liunkae

featurcontext-menu fixed-with-brave-core prioritP5 project-tracking wontfix

All 5 comments

@bsclifton What about the Windows menubar?

@Liunkae that would be a REALLY nice one actually! Good catch 馃槃

(please edit the original post if needed)

I do see something about drag and drop handling in MenuController of ui/views/controls/menu/menu_controller.cc

@Liunkae did you want to redo the reload/stop button with native context menu? I remember you had originally submitted the PR with it as a native menu, but we changed back (at my request, since macOS menus were sync at the time)

Sure. I opened #9571 for this.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

mykkymk picture mykkymk  路  3Comments

luixxiul picture luixxiul  路  3Comments

jonathansampson picture jonathansampson  路  3Comments

stevespringett picture stevespringett  路  3Comments

luixxiul picture luixxiul  路  3Comments