This issue is meant to track places which use our React component which we can convert to using native context menus. This works great on Windows and Linux, but macOS causes video to freeze when the context menu is presented. The above PR makes that process async
Places we can update:
Places we can consider updating (which have moderate difficulty):
Places which we shouldn't change (requires a lot of extra work to do natively):
cc: @Liunkae
@bsclifton What about the Windows menubar?
@Liunkae that would be a REALLY nice one actually! Good catch 馃槃
(please edit the original post if needed)
I do see something about drag and drop handling in MenuController of ui/views/controls/menu/menu_controller.cc
@Liunkae did you want to redo the reload/stop button with native context menu? I remember you had originally submitted the PR with it as a native menu, but we changed back (at my request, since macOS menus were sync at the time)
Sure. I opened #9571 for this.