Browser-laptop: Unhide bitwarden password manager

[bsclifton]

Test plan

https://github.com/brave/browser-laptop/pull/8829#issue-227873469
https://github.com/brave/browser-laptop/pull/6918#issue-203925870

---

Once https://github.com/brave/browser-laptop/issues/7830 is supported, we can revert https://github.com/brave/browser-laptop/commit/0744193d30c4b765f9709c66e0bb3e9d73a6a246

7919 #4776

[kspearrin]

Can we unhide now that #7830 is closed?

[bsclifton]

@kspearrin absolutely- we'll need a new version of Muon. I'll set a milestone for the release after the current one. If you'd like, you could submit a revert of the above as a PR 😄

[kspearrin]

@bsclifton Done. https://github.com/brave/browser-laptop/pull/8776

[kspearrin]

I somehow screwed up #8776 into a state that I didn't know how to recover from, so I started over with #8829. Sorry :-/

[kspearrin]

@bsclifton Just trying to get an idea here. We'd like to prepare some announcement material to inform our users. What version of brave is slated to have bitwarden available in it?

[bsclifton]

@kspearrin comment left here:
https://github.com/brave/browser-laptop/pull/6918#issuecomment-308276441

Basically, it's in our 0.17.x releases. Here's a link to the latest, if you wanted to test it out 😄
https://github.com/brave/browser-laptop/releases/tag/v0.17.1dev

We should be able to ship within 1-2 weeks 😄

[kspearrin]

@bsclifton How do extension updates work in brave? I'm testing with 0.17.1 and am getting a very outdated version of bitwarden (1.10.0) that is full of issues because it's using server APIs that are not backwards compat anymore.

[bsclifton]

@kspearrin right now, it's a manual process we have to run (I'm looking at automating the update process). I should be able to safely bump bitwarden without an issue. Hang tight...

[kspearrin]

@bsclifton Ok, no worries. We do have a somewhat critical update coming out today or tomorrow that I would like to ensure brave gets updated to before the release.

[kspearrin]

@bsclifton Issue created #9479

[luixxiul]

The bitwarden icon is not displayed on a web page, while it is on an about page such as about:preferences.

[bsclifton]

Moving to 0.18.x hotfix because we ran into an issue https://github.com/brave/browser-laptop/issues/10130

[luixxiul]

This should be fixed after https://github.com/brave/browser-laptop/commit/38f46189571710189a3702926d8d40b465fc953a

https://github.com/brave/browser-laptop/issues/10130#issuecomment-317903948

[kspearrin]

Was this unhidden for the 0.18.x hotfix as @bsclifton mentioned? I can't find a branch for that. I only see 0.18.x and bitwarden is still hidden there.

[jonathansampson]

@kspearrin I'm about to take a closer look at this issue. Aiming to resolve asap, and ship.

[kspearrin]

@jonathansampson ok. Please let me know if/when there is a branch I can look at/test.

Also, we just pushed a new version, 1.14.2 , to the chrome store today. It would be nice if that update made it in as well since I know auto updates is a missing feature at the moment.

[bsclifton]

@kspearrin good call- we do need to unhide it. This issue was closed prematurely when a different commit / issue was resolved. I'll re-open and unhide it shortly

[bsclifton]

Issue is now resolved after committing https://github.com/brave/browser-laptop/commit/2c2e19afb5b2ae33a2567d85704aa9dfb86fca2d 😄

cc: @kspearrin, @jonathansampson, @luixxiul

[bsclifton]

@kspearrin you can try it out using the 0.18.x branch OR if you wait until we have a new build on the dev channel (if you have preview releases enabled- see advanced tab of preferences). We may have a new packaged build tonite or tomorrow

[kspearrin]

@bsclifton I will wait for the new dev build.

[bsclifton]

Tentatively moving to 0.19.x - we've got it disabled for now because of issues we ran into. We'll continue working away at those and plan to release with 0.19.x

[bsclifton]

Let's track this with https://github.com/brave/browser-laptop/issues/4776 instead