Browser-laptop: On disable switch make the text grayed out
Test plan
See https://github.com/brave/browser-laptop/pull/12455
Original issue description
Did you search for similar issues before submitting this one?
Describe the issue you encountered:
Platform (Win7, 8, 10? macOS? Linux distro?):
Brave Version (revision SHA):
Steps to reproduce:
1.
2.
3.Actual result:
Expected result:
Will the steps above reproduce in a fresh profile? If not what other info can be added?
Is this an issue in the currently released version?
Can this issue be consistently reproduced?
Extra QA steps:
1.
2.
3.Screenshot if needed:
Any related issues:
srirambv
All 16 comments
Like this?
luixxiul
on 9 Mar 2017
Yes
srirambv
on 9 Mar 2017
CC @bradleyrichter for a comment
luixxiul
on 9 Mar 2017
yes please
bradleyrichter
on 9 Mar 2017
Should be easy to do- here's where you'd want to edit:
https://github.com/brave/browser-laptop/blob/master/app/renderer/components/settings.js#L41
bsclifton
on 10 Mar 2017
When would the switch be disabled?
This shouldn't be off state if that's what is meant.
bbondy
on 12 Mar 2017
@bradleyrichter would you want this grayed out when disabled? Or also when the switch is turned to off?
bsclifton
on 12 Mar 2017
I would only grey out when checkbox is disabled
NejcZdovc
on 12 Mar 2017
Correct. Only if a switch is disabled, not toggled off. I think we currently have few examples of this.
On Mar 11, 2017, at 11:16 PM, Nejc Zdovc notifications@github.com wrote:
I would only grey out when checkbox is disabled
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
bradleyrichter
on 12 Mar 2017
Moving to 0.13.7
bsclifton
on 13 Mar 2017
Example in Preferences > Plugins:
It looks like the shields panel already has this behavior:
cndouglas
on 18 Mar 2017
Removing milestone
bsclifton
on 4 Apr 2017
I'd like to attempt a PR for this if no on else is working on it.
Is there any way to use the browser's Developer tools to debug the browser's UI? This would help me understand the code better and debug.
chirag64
on 4 Apr 2017
Shift+F8 activates the devtool ;-)
luixxiul
on 4 Apr 2017
Attached a screenshot in the pull request as well, thank you for reviewing. 😄
user512
on 1 Jan 2018
Verified on Windows 10 x64 using
- 0.23.11 6565c06
- Muon 7.1.0
- libchromiumcontent 67.0.3396.87
Verified on Ubuntu 17.10 x64
- 0.23.12 - 88f6f0767c05ba5c4793ec2430a5cd742092fa6d
- Muon - 7.1.1
- libchromiumcontent - 67.0.3396.87
Verified on macOS 10.13.4 x64 using the following build:
0.23.1288f6f0767c05ba5c4793ec2430a5cd742092fa6d- muon:
7.1.1 - libchromiumcontent:
67.0.3396.87
srirambv
on 19 Jun 2018
Related issues
luixxiul
·
3Comments
stevespringett
·
3Comments
shortstuffsushi
·
3Comments
bsclifton
·
3Comments
antiroyalty
·
3Comments