Browser-laptop: lock icon is sticky in URL bar when it should display search icon

Created on 16 Dec 2016  路  4Comments  路  Source: brave/browser-laptop

image

Qchecked-Linux Qchecked-Win32 Qchecked-Win64 Qchecked-macOS Qtest-plan-specified bug featurURLbar release-noteinclude

All 4 comments

Just a note:

To reproduce you have to go to google.com (which shows the lock) and then start typing a search (which shows the magnifying glass) but then click back to the google.com page. Now if you go to the URL it shows your search text but still shows the lock which it should not.

thanks! I was just having a hard time reproducing this one...

Closing as this was fixed with https://github.com/brave/browser-laptop/pull/6319

Test Plan:

  • enable "always show URL bar", to make testing easier
  • go to google.com and notice the lock in the omnibox
  • start typing a search into a the omnibox and notice icon changes to magnifying glass
  • click inside the webpage. icon should stay as magnifying glass and search terms should still be shown. This confirms the fix (the bug before was that it would revert to showing the lock icon next to the search terms)
  • click in the omnibox and press escape. This should reset icon back to lock and reset input back to google.com

@bsclifton Thanks for the test plan! :+1:

Was this page helpful?
0 / 5 - 0 ratings

Related issues

jonathansampson picture jonathansampson  路  3Comments

jonathansampson picture jonathansampson  路  3Comments

bbondy picture bbondy  路  3Comments

bbondy picture bbondy  路  3Comments

luixxiul picture luixxiul  路  3Comments