Browser-laptop: Building with Hyper.js - project stuck loading

[rickyrauch]

Did you search for similar issues before submitting this one?
Yes
Describe the issue you encountered:
When building (fresh install) I've got this:

Expected behavior:
Running brave

• Platform (Win7, 8, 10? macOS? Linux distro?):
  macOS Sierra

• Brave Version:
  Master

• Steps to reproduce:

  1. npm run watch
  2. npm start

• Screenshot if needed:
  

• Any related issues:
  https://github.com/brave/browser-laptop/issues/3559

[rickyrauch]

Log https://gist.github.com/rickyrauch/0b185c1f085be322ba61b91714dbd7b5

[bsclifton]

@rickyrauch can you try hitting shift+F8? this will open the electron developer tools which show the console errors for the application itself. You should get more info

[rickyrauch]

@bsclifton I think it doesn't work shift+F8 on mac. I clicked Toogle dev tools from the menu bar and it doesn't work neither.

Thanks

[bsclifton]

@rickyrauch shift+F8 should definitely work on Mac; if you're using a laptop (ex: MacBook Pro, etc) make sure you press the fn key (required when you push F8).

You should also be able to toggle it by using the Debug menu and picking Toggle Browser Console.

[rickyrauch]

@bsclifton Uncaught ReferenceError: AIzaSyAQfxPJiounkhOjODEO5ZieffeBv6yft2Q is not defined browser.js:148

Thanks!

[rickyrauch]

@bsclifton the problem is when I try to build using Hyper.js. Otherwise works ok.

[bsclifton]

@rickyrauch do you still have this issue? I wonder if it's limited to Hyper.js?

Disregard, I can't read :stuck_out_tongue: You say in your last comment it works OK otherwise :smile:

[rickyrauch]

Hi @bsclifton

It works using Terminal.app
It doesn't work using Hyper.js

Thanks!

[jkup]

Hey @rickyrauch ! I just ran into this the other day. The problem is that Electron (which both Hyper and Brave use) sets a GOOGLE_API_KEY environment variable which we both use. You can unset that var by opening hyper and typing:

unset GOOGLE_API_KEY

And if it helps, you can just put that unset command in your ~/.bashrc so it will run any time you open hyper!

@bsclifton is there anything we can do about this? Or should we close this ticket out? Maybe we can add it to the documentation somewhere?

[rickyrauch]

hahahah it makes sense.

[bsclifton]

@jkup adding it to the documentation would be great :smile: If you were able to add a quick note to our wiki, we could definitely close this out:
https://github.com/brave/browser-laptop/wiki/Troubleshooting

[rauchg]

@jkup we also ran into that somehow. I believe this is Electron leaking that env? cc @zcbenz @zeke @kevinsawicki

[rauchg]

Also @tootallnate pulled his hairs out a good amount over this IIRC

[jkup]

Thanks @rauchg! I'm gonna close this out now since I added a workaround for the docs here (https://github.com/brave/browser-laptop/wiki/Troubleshooting#browser-starts-and-opens-the-window-but-never-loads-the-main-frame-and-there-is-a-stack-trace-in-the-browser-dev-console)! But if any of the fine electron folks tagged above have a better long term issue I would love to hear it!

[zeke]

Anyone know if there is an issue on electron/electron for this?

[jkup]

@zeke I don't think there is. When I was looking last night for a fix I stumbled on this zeit/hyper issue https://github.com/zeit/hyper/issues/696 which links to electron but no mention of an actual issue. Should I file one?

[zeke]

Should I file one?

Yes, please. :)

[jkup]

@zeke filed! (https://github.com/electron/electron/issues/8212) Thanks so much for your help! + @rauchg