Browser-laptop: Add Bitwarden Password Manager
Test plan
https://github.com/brave/browser-laptop/pull/6918#issue-203925870
Original issue description
Open source cross platform cloud manager. There's an available chrome extension as well.
Issue status
We've been trying to get support for this in place and we've slipped several releases (not enough resources to support / troubleshoot). This feature can now be added by reverting this change (minus the Pinterest part)
https://github.com/brave/browser-laptop/commit/4cae9819e61ad276de57a0d6b2972da5159c41ce
blindly
All 31 comments
Available on chrome web store here: https://chrome.google.com/webstore/detail/bitwarden-free-password-m/nngceckbapebfimnlniiiahkandclblb
kspearrin
on 30 Jan 2017
QA blocked waiting for Muon update
luixxiul
on 15 Mar 2017
The icon of the extension appears, still the extension does not seem to work yet on https://trac.torproject.org/projects/tor/login.
luixxiul
on 22 Mar 2017
Changed to no-qa-needed as the option has been disabled in settings
srirambv
on 30 Mar 2017
Hello, is this feature still in development, or has it been shelved?
ChillyHellion
on 19 Jul 2017
Hi there @ChillyHellion - sorry it's taken a while to make progress here
Our beta channel (0.18.x) should have this available... we still needs to perform manual testing, but you can try the latest beta build here. Please note that our beta channel won't be as stable as our main channel (which is still marked as dev; we need to update the name to stable or similar)
Definitely not shelved 馃槃 Apologies it's taken longer than expected
bsclifton
on 19 Jul 2017
Thanks bsclifon, and not a problem! I just wanted to know if this was still in the works or if there was a technological roadblock preventing the implementation. I appreciate the timely reply and I may take you up on testing out a beta build. Bitwarden is one of my favorite web services and Bitwarden + Brave seems like a match made in heaven.
ChillyHellion
on 19 Jul 2017
Moving this issue to 0.18.x to ensure we perform manual QA against Bitwarden 馃槃
bsclifton
on 19 Jul 2017
Moving to 0.18.x hotfix because we ran into an issue https://github.com/brave/browser-laptop/issues/10130
bsclifton
on 25 Jul 2017
@bsclifton I appreciate your persistence and the special interest you've taken in implementing this feature. You're doing a great job!
ChillyHellion
on 26 Jul 2017
Tentatively moving to 0.19.x - we've got it disabled for now because of issues we ran into. We'll continue working away at those and plan to release with 0.19.x
bsclifton
on 9 Aug 2017
For the specific open issues, please see:
- bitwarden issues while testing #10202
- bitwarden: Site autofill doesn't work #10140
- bitwarden extension header buttons are not clickable #9436
@jonathansampson @kspearrin when working in dev and testing compatibility, please try the revert mentioned in the original post above
bsclifton
on 9 Aug 2017
I'll follow up on this one to establish status.
ghost
on 15 Aug 2017
I was still having issues using Brave's implementation of Bitwarden - I could log in correctly but trying to access my fault just left the UI loading indefinitely. I completely uninstalled Brave, cleared its AppData, and reinstalled Brave fresh using the latest stable build and noticed that Bitwarden is now removed from the list of extensions.
Hopefully this is just temporary while bugs are worked out; Bitwarden support is the last thing keeping me from moving over from Firefox completely. All of my other extensions (https anywhere, uBlock, disconnect, privacy badger) are things that Brave does natively.
ChillyHellion
on 21 Aug 2017
@kspearrin @jonathansampson if you wanted to try the latest 0.19 release which has bitwarden enabled, please check out a release I built just for you 馃槃
https://github.com/brave/browser-laptop/releases/tag/v0.19.3beta
This is part of the beta channel (which is something that is still a work in progress). I'd recommend installing this version and then (after testing is complete) reverting back to the last stable version. Coming soon (thanks to @darkdh) we'll have multiple channels installable at the same time
bsclifton
on 22 Aug 2017
cc: @ChillyHellion in case you wanted to try the beta
bsclifton
on 22 Aug 2017
Thanks, I'll have to check this out!
ChillyHellion
on 22 Aug 2017
@bsclifton No issues with this build so far, this is wonderful!
ChillyHellion
on 22 Aug 2017
@kspearrin @jonathansampson The login popup is unusually large on 0.19.x. Is this expected?
srirambv
on 29 Aug 2017
@srirambv What is your screen resolution?
kspearrin
on 29 Aug 2017
@kspearrin Its 1920x1080 with DPI set at 125%. The browser UI scale is default.
srirambv
on 29 Aug 2017
Yea, that doesn't look right. 0.19.x did have an increase in size for the popup window, but it's height is still < 700 px. Looks like a brave issue.
kspearrin
on 29 Aug 2017
@srirambv I suspect this is a general scaling issue. If you lower your to 100%, does it resolve the issue? I believe this is the same issue documented in #7051.
jonathansampson
on 29 Aug 2017
@srirambv I captured the high DPI issue with https://github.com/brave/browser-laptop/issues/10706. I'll go ahead and close this issue out since it's merged to 0.19.x and there haven't been any other reports of issues
bsclifton
on 29 Aug 2017
Did Bitwarden support make it into stable? I was using Bitwarden without issue in the Brave Beta build linked farther up in this thread, but a recent update to that build leaves me unable to sign into Trello. If I revert back to stable will I miss out on Bitwarden?
ChillyHellion
on 3 Oct 2017
@ChillyHellion our beta which has bitwarden is nearing completion- we expect to release it this week 馃槃 Our last release of 0.19.x has most of the functionality, we're just ironing out bugs at this point. Stay tuned 馃槃
bsclifton
on 10 Oct 2017
Excellent, thank you for the status update!
ChillyHellion
on 10 Oct 2017
I received the update for 0.19.53 and can confirm that Bitwarden is included and working perfectly! Thank you so much for all of your time and effort!
ChillyHellion
on 17 Oct 2017
@ChillyHellion this is great! Thanks for the update (and enjoy! 馃槃 )
bsclifton
on 17 Oct 2017
It's great to have Bitwarden back with the latest update. However, it keeps loading its welcome Tab (with the video) each time I start Brave. Is there a way to stop this? I haven't asked Brave to display previous Tabs when it opens.
Wyvern2
on 19 Oct 2017
@Wyvern2 great catch- we noticed this with a few other extensions... @darkdh has prepared a fix which we should be able to include in our next version 馃槃
bsclifton
on 20 Oct 2017
Related issues
jkup
路
3Comments
antiroyalty
路
3Comments
luixxiul
路
3Comments
briannyeko
路
3Comments
stevespringett
路
3Comments
Most helpful comment
I received the update for 0.19.53 and can confirm that Bitwarden is included and working perfectly! Thank you so much for all of your time and effort!