Browser-laptop: Ledger recovery should be aware of network status and give appropriate errors when the connection is down.

[alexwykoff]

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
While trying to recover a wallet, my network connection went down. The error message from the system indicated that my keys were somehow incorrect. Once the network connection was restored, the keys worked without issue.

Expected behavior:
The system should display appropriate error messages.

• Platform (Win7, 8, 10? macOS? Linux distro?):
  Tested on OS X
• Brave Version:
  0.12.5
• Steps to reproduce:
  
  
  
  1. Generate recovery keys
  
  
  2. Remove your ~brave folder and create a new wallet
  
  
  3. Open the recovery dialog, enter keys but do not submit the form
  
  
  4. Disable your network connection (or just happen to have a really poor one)
  
  
  5. Submit the form
  
  
  6. Observe the error message
  
  
• Screenshot if needed:
  
• Any related issues:

Test Plan

1. Go to Preferences > Payments
2. Click Advanced Settings
3. Click Recover Your Wallet
4. Try to recover with the wrong keys
5. You should see the "Recovery Failed" overlay
6. Repeat steps 1-3
7. Turn off network connection
8. Try to recover with right or wrong keys
9. You should see the "Network Error" overlay

[bsclifton]

Groundwork laid by @mrose17 w/ https://github.com/brave/browser-laptop/pull/5924

This is ready for the UI work. Marking as 0.13.1 and assigning over to @jkup

[jkup]

@bsclifton did you mean to close this?

[mrose17]

it shouldn't have been closed. i did the first part, but now it's up to you!!!

[bsclifton]

Looks like the self-closing keywords from the commit unintentionally closed it :smile:

...
For the person who fixes #4720 - when...

[mrose17]

rather amusing...

[mrose17]

@bsclifton - can we close this one too?

[luixxiul]

@mrose17 I don't think so. #6047 focuses on the UI change.

[jkup]

@mrose17 reading through your commit I'm still not sure how I can differentiate between a network error and a failed recovery (bad keys). Can you help me understand how to do this UI work?

Thanks!!

[bsclifton]

@mrose17 looks like @jkup needs some more info (he should be back next week)

I'm still not sure how I can differentiate between a network error and a failed recovery (bad keys). Can you help me understand how to do this UI work?

[mrose17]

here is the answer: look at ledgerInfo.error.err if it is a STRING, then there is a data input or server error; if it is an object, e.g., { errorCode: -109 } then there is a network error.

[luixxiul]

It seems this is not fixed. I followed the same steps after restarting the browser but it did not work either

[alexwykoff]

In my case, the breakage was a bit nuanced.
Without a network connection, the UI did nothing. No warning, no error, it just took my clicks and walked away.

When the network connection was restored, somewhere in the middle of my machine-gunning the control, the recovery keys were accepted.

cc @bsclifton

[bbondy]

Moved to 0.13.3

[bsclifton]

Removing milestone for now and putting on backlog- we're tracking in Asana. Will update once we have prioritized

[ghost]

Closing at @mrose17 direction.