Browser-laptop: Brave doesn't remember last position and size if you set it to start with homepage

[Sh1d0w]

Test plan

1. Open preferences > general
2. Set Brave starts with to My homepage
3. Move the window to a unique position and resize it also
4. Close Brave and reopen
5. Window should have retained its position

Original issue description

Did you search for similar issues before submitting this one?
No

Describe the issue you encountered:
When closed Brave does not retain last window position and size as it should be when re-launched.

_This happens only if_ in Settings -> General you set the value for Brave starts with to My homepage. If you select Session and tabs from last time it correctly remembers the position and the size of the window.

Expected behavior:
Brave should remember the last window position and size regardless what I choose Brave to load initially.

• Platform (Win7, 8, 10? macOS? Linux distro?):
  Linux, Fedora 24
• Brave Version:
  0.12.0dev downloaded from here
• Steps to reproduce:
  
  
  
  1. In settings -> general set Brave starts with to My homepage
  
  
  2. https://s11.postimg.org/y5tetpkkj/window_bug.gif
  
  
• Screenshot if needed:
• Any related issues:

[bsclifton]

Good call, @Sh1d0w! I just manually tested and confirmed #4482 does seem to fix this issue

[Sh1d0w]

Unfortunately after I installed 0.12.4 it does not seem to fix this issue. The problem still exists if you follow the STR in the issue above.

Set Brave starts with to My home page and observe that resizing and closing the window, always launches in fullsize when you relaunch the browser. Brave should remember its last position and size regardless of the option set for Brave starts with

[bbondy]

if you select my home page then no last window state is saved. I guess we need to use the last window size / pos in that case for the next new Window.

[Sh1d0w]

@bsclifton Here is a video from latest master https://github.com/brave/browser-laptop/commit/af38d76dced4a1124762a12377340c1a925c1989

http://webm.land/media/Q5tA.webm

Does not seem to work for me :(

I am resizing the window via double click in the header, not sure if the resize event is fired then. And in the drag event you only save the position and not the size. Maybe that's why it is not working. Can you please double check this case?

[srirambv]

Verified on Windows. Its loading the window in the default restore down position when home page is set to start.

[bsclifton]

@srirambv code has not been included in a preview or release yet

@Sh1d0w I'll dig in more

[bsclifton]

@Sh1d0w it looks like you've launched one of our releases; this hasn't been included in a built yet. I'm going to close this, but please try it from source; I can't reproduce.

[bsclifton]

OK I missed the above being master (@Sh1d0w had packaged the build and installed/ran that)

If he moves the session out of the way, it works fine. But with session in place, it's not working.

Re-opening issue...

[Sh1d0w]

Reopening since it is still not fixed. @bsclifton Ping me in slack so we can cooperate to resolve this.

[bbondy]

Going to spin rc1 so moving this to 0.12.8. If we do an rc2 which is probably likely we'll get it in.

[bsclifton]

Removing milestone for the time being

[srirambv]

Two more reports from support on not remembering window position
https://linkbubble.zendesk.com/agent/tickets/7082
https://linkbubble.zendesk.com/agent/tickets/7079

[srirambv]

+1 from community https://community.brave.com/t/brave-forgets-window-size-on-opening/3233