Browser-laptop: Bookmark folder is created left of bookmark item, not right

Created on 29 Jul 2016 · 12Comments · Source: brave/browser-laptop

Test plan

https://github.com/brave/browser-laptop/pull/10136#issue-245629798

Describe the issue you encountered: Bookmark folder is created left of a bookmarked item. It's the same after moving brave folder in AppData\Roaming.

Expected behavior: It should be created right of the item

Platform (Win7, 8, 10? macOS? Linux distro?): Windows 7 64 bit
Brave Version: 0.11.2 Beta1
Steps to reproduce:
1. Bookmark https://github.com from the bookmark toolbar
2. Create a bookmark folder
Screenshot if needed:
Any related issues: #2768

Qchecked-Linux Qchecked-Win64 Qchecked-macOS Qtest-plan-specified bug design featurbookmarks release-noteinclude

Source

luixxiul

All 12 comments

Valid bug, but it won't block 0.11.2 release. It seems to always put it at the right spot except when it is the last item it puts it second last.

bbondy on 29 Jul 2016

I noticed this too. New bookmark folders seem to always be put in the next-to-last position.

anseljh on 3 Aug 2016

@bradleyrichter this is worth a moment of design thought. Perhaps all folders should go to the far left of the bookmarks tray?

alexwykoff on 23 Aug 2016

Appearing on the left is the Safari way. Appearing on the right is the Chrome/Firefox way.

On a crowded bar, the Left approach insures that it can be seen when added. But the cost is pushing things into the chevron menu.

Following the most popular browsers usually creates less user friction even when there is a slightly better way. So on this one, let's fix this bug, and follow chrome/FX.

bradleyrichter on 23 Aug 2016

Just to make sure you guys are understanding the bug:

I start with N items on my bookmarks bar.
I right-click the bookmarks bar and select "Add Folder..."
I type in a name for my new folder ("Stuff") and click "Save".
My new "Stuff" folder is in the Nth position. The item that was previously Nth is now N+1th.

What makes sense _to me_ is to always place the new item last (N+1th), and then let the user move it somewhere else if they want to.

anseljh on 23 Aug 2016

@anseljh yes, understood.

@alexwykoff was suggesting/questioning changing the behavior which would also fix this bug. But I am suggesting that we fix it as you explained. New items should be last. Not second-last.

bradleyrichter on 23 Aug 2016

👍1

Still an issue in 0.13.0

add_bookmark_folder_left