Brave-ios: Sync UI Updates

[jamesmudgett]

Update Sync UI and strings

sync_ios.zip

Specs -
Mobile Sync Updates.pdf

[jamesmudgett]

Paste icon -
paste.zip

[LaurenWags]

@jamesmudgett Settings shows Sync, not Brave Sync, expected? Generally there are inconsistencies with the screenshots above, are there more updated screens somewhere?

[iccub]

You are right @LaurenWags, I talked to the designers team and we will change it to Brave Sync
However this will go out after 1.9 release, as this string needs to be translated

Added a ticket here https://github.com/brave/brave-ios/issues/973

[GeetaSarvadnya]

@iccub There are few discrepancies between the above-proposed screenshots and sync screens in 1.9 (19.03.25.21) - which are listed below, will these be addressed in #973?

[iccub]

@GeetaSarvadnya I will let @anthonypkeane to answer this

[iccub]

Strings with Sync/Sync beta will be fixed in https://github.com/brave/brave-ios/issues/973
I have a sync code string is correct, please look at updated version of spec here https://github.com/brave/brave-ios/files/2770209/Mobile.Sync.Updates.pdf

Remaining strings are wrong and will be fixed in this PR https://github.com/brave/brave-ios/pull/1003

[kjozwiak]

@iccub assuming these changes haven't made it into 1.9 (19.03.25.21) as https://github.com/brave/brave-ios/pull/1003 is still opened? Are we going to be getting another RC build that will include the changes from https://github.com/brave/brave-ios/pull/1003?

[iccub]

@jhreis please decide on that ^

[srirambv]

String changes can be put in 1.10. Don't want to hold on the release for text changes.

[srirambv]

Blocked on #973

[LaurenWags]

@jamesmudgett @jhreis @iccub a few questions about this:

1. noticing some inconsistencies in strings/wording in various places. is this expected? not sure if the image from the original description has been changed intentionally. Happy to log follow up issues if desired.
2. the two images at the bottom of the original description - are they supposed to be how these screens display on an iPad? because that's not currently the case. (see below, I put blue rectangles around the images I'm asking about) again - can log follow ups, just wasn't sure if original design had changed.
   

[jamesmudgett]

@LaurenWags since iPad is currently displaying sync modally (smaller window) it will appear similar to iPhone which is OK.

[LaurenWags]

• Verified passed on iPad 5th Gen (iOS 12.3.1) running 1.10 (19.07.16.23)
  
  
  
  • Verified Sync UI per image in description (making exceptions for changes noted in this release).
  
  
  • Logged two follow up issues for minor inconsistencies in wording and tagged @anthonypkeane to review the issues: #1273 and #1274
  
  
• Verification PASSED on iPhone 6s+ running iOS 12.3.1 using 1.10 (19.07.16.23)

[kjozwiak]

@jhreis @jamesmudgett should this be placed into the 1.10 ZenHub release rather than the Sync release?

[kjozwiak]

@EyanGoldman @anthonypkeane mind quickly going through this on a iPhone X to make sure the UX/layout looks correct?

[EyanGoldman]

No issues regarding notch compatibility. Looks good on the iPhone X