Brave-ios: Remove Firefox branding on Error Pages
Remove Firefox branding
Steps to Reproduce
- See screenshot under Additional Information
Actual result: Firefox branding is shown
Expected result: Brave branding should be shown
Reproduces how often: Every time
Brave Version: Latest development build hash 6671f428bcdad3a22d361519161abfbe1ce39d8a
Device details: iPad Pro 10.5" iOS 11.4.1
Additional Information
tmancey
All 4 comments
In 1.6 we actually display a popup as such:
So question is whether or not we want to just keep this intermediate page and change the copy to say Brave instead of Firefox or remove it entirely for the alert.
kylehickinson
on 20 Sep 2018
@tomlowenthal can I get your input on this one.
My recommendation is that we implement the newer “Firefox” solution. Can you confirm you are okay with this?
anthonypkeane
on 28 Sep 2018
The newer Firefox behavior of displaying a modal popup is a lot worse from a security & UX perspective. We should stick with an interstitial which requires two taps to continue, but re-brand as Brave. Ideally, we should re-style this page (all error insterstitials) to match @rossmoody's updated error page designs for desktop, but that's not this issue.
tomlowenthal
on 2 Oct 2018
@tomlowenthal The two-tap interstitial is actually the newer Firefox behaviour that we have now in 1.7, where as the popup is the live version.
But good to know we will first replace the copy on this page and ideally down the road implement the re-design :)
kylehickinson
on 2 Oct 2018
Related issues
oloverm
·
6Comments
bsclifton
·
4Comments
VimS
·
6Comments
jumde
·
8Comments
kylehickinson
·
6Comments
Most helpful comment
@tomlowenthal The two-tap interstitial is actually the newer Firefox behaviour that we have now in 1.7, where as the popup is the live version.
But good to know we will first replace the copy on this page and ideally down the road implement the re-design :)