Brave-ios: Peek/pop 3D touch

Created on 7 May 2019  路  6Comments  路  Source: brave/brave-ios

Description:

Not being able to use peek and pop on links or images is the only thing that makes me want to switch back to Safari. The long press is just too slow and it doesn鈥檛 show you the peek preview.

QYes enhancement good first issue iOS 12 iPhone-specific release-noteinclude won't have

All 6 comments

Hey guys 馃憢

If you do not mind and nobody is working on this issue, I would like to give it a shoot as a first good issue 馃檪馃挭

Peek and Pop will be a great feature to have in Brave browser, I am very excited about it 馃殌

I wonder if it's even worth implementing given that 3d touch could be removed in the future

https://forums.macrumors.com/threads/apple-expected-to-remove-3d-touch-from-all-2019-iphones-in-favor-of-haptic-touch.2182908/

@mollyIV our project manager @jhreis is on PTO, I will ping him after he's back to answer you :)

馃憢 I opened a draft pull request to make a discussion easier 馃檪

https://github.com/brave/brave-ios/pull/1108

We had to revert this due to iOS 13 gesture conflicts (commit https://github.com/brave/brave-ios/commit/b3f412b9effddf32204463ca478d1e6a3bef0317). Re-opening for now.

This isn't easy to fix in iOS 12, iOS 13 support this out of the box.
Labelling as won't have for versions earlier than iOS 13

Was this page helpful?
0 / 5 - 0 ratings

Related issues

iccub picture iccub  路  4Comments

kylehickinson picture kylehickinson  路  6Comments

srirambv picture srirambv  路  3Comments

ryanbr picture ryanbr  路  5Comments

VimS picture VimS  路  6Comments