Brave-browser: chrome incognito icon is used in allow cookies sites list

Created on 16 Sep 2020  路  5Comments  路  Source: brave/brave-browser

Description

chrome incognito icon is used in allow cookies sites list

Steps to Reproduce

  1. Open Brave 1.16.x or 1.14.x
  2. Visit brave://settings/cookies
  3. Open a PT window and visit any site
  4. Come back to brave://settings/cookies again
  5. chrome incognito icons are displayed under Sites that can always use cookies section

Actual result:

image

Expected result:

Brave branded icons should be displayed

Reproduces how often:

Always

Brave version (brave://version info)

Brave | 1.16.19 Chromium: 86.0.4240.30聽(Official Build)聽nightly聽(64-bit)
-- | --
Revision | 09f50eb5535879364cf00e72653462a509ef6bdc-refs/branch-heads/4240@{#552}
OS | Windows聽10 OS Version 1903 (Build 18362.1016)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:


cc: @brave/legacy_qa @rebron

ODesktop QA Pass-Linux QA Pass-Win64 QTest-Plan-Specified QYes branding bug prioritP3 release-noteexclude
Source
picture GeetaSarvadnya

All 5 comments

@brave/design @mherrmann will help us with this if you can point us to which icons to use.

mihaiplesa picture mihaiplesa on 5 Nov 2020
👍1

We need a 20x20 SVG to replace the icon in the above screenshot.

mherrmann picture mherrmann on 5 Nov 2020

Here you go!

private-mode.svg.zip

karenkliu picture karenkliu on 5 Nov 2020

Thank you @karenkliu!

mherrmann picture mherrmann on 6 Nov 2020

Verification passed on


Brave | 1.18.57 Chromium: 87.0.4280.66聽(Official Build)聽beta聽(64-bit)
-- | --
Revision | fd98a29dd59b36f71e4741332c9ad5bda42094bf-refs/branch-heads/4280@{#1432}
OS | Windows聽10 OS Version 2004 (Build 19041.572)
  • Verified the STR from the description

Light mode:
image

Dark mode:
image

Verification passed on

Brave | 1.18.62 Chromium: 87.0.4280.67聽(Official Build)聽dev聽(64-bit)
-- | --
Revision | 0e5d92df40086cf0050c00f87b11da1b14580930-refs/branch-heads/4280@{#1441}
OS | Ubuntu 18.04 LTS

  • Verified the STR from the description

Light mode:
image

Dark mode:
image

GeetaSarvadnya picture GeetaSarvadnya on 19 Nov 2020
🎉1
Was this page helpful?
0 / 5 - 0 ratings

Related issues

jonathansampson picture jonathansampson  路  3Comments
bsclifton picture bsclifton  路  3Comments
pitsi picture pitsi  路  3Comments
bbondy picture bbondy  路  3Comments
traffisco picture traffisco  路  3Comments