Brave-browser: [Android] Bottom bar tab swipe is not working

Created on 9 Jul 2020 · 8Comments · Source: brave/brave-browser

Description

Bottom bar tab swipe is not working

Steps to reproduce

Install 1.13.2 and open a bunch of tabs
Swipe on the bottom bar to switch between tabs
Doesn't swipe

Actual result

Bottom bar tab swipe is not working

Expected result

Should switch to tabs back./forward based on swipe direction

Issue reproduces how often

Easy

Issue happens on

Current Play Store version? No
Beta build? Yes

Device details

Install type (ARM, x86): ARM
Device (Phone, Tablet, Phablet):Phone
Android version: 10

Brave version

1.13.2

Website problems only

Does the issue resolve itself when disabling Brave Shields? NA
Does the issue resolve itself when disabling Brave Rewards? NA
Is the issue reproducible on the latest version of Chrome? NA

Additional information

cc: @samartnik

Chromiuwaiting upstream OAndroid QA Pass - Android ARM QYes android-phone-specific bug regression release-noteexclude

Source

srirambv

👍12

Most helpful comment

Would also love to see this working again. It is one of the best tab surfing features and very essential, imho.

szaimen on 5 Aug 2020

👍8

All 8 comments

This needs to be fixed and uplifted for 1.11.x as its broken on 1.11.93 as well. Possibly due to CR bump?

cc: @SergeyZhukovsky

srirambv on 13 Jul 2020

👍3

Removed as part of https://chromium.googlesource.com/chromium/src/+/6db06b5cc4b9c167b8bd70e5ff20953b6b158406. Will waiting for upstream as per internal discussion https://bravesoftware.slack.com/archives/C0816QH3R/p1594645727110100

srirambv on 13 Jul 2020

👍3

At least the top bar swipe still functions. However, if you did swipe the top bar to change tabs, the bottom bar's "ghost" still remains and blocks part of the page.

If upstream decides to remove it, I guess Brave should follow suit as they may implement another functionality, however that functionality is currently nonexistent so I guess it wouldn't hurt to roll back this change. It's useful too.