Brave-browser: Duplicated top site entries after update

[congard]

Description

After updating to the last nightly and opening Google Translate from top sites bar, this bug occurred. Instead of my sites, there were only pinned ones. In addition, the GitHub icon has disappeared (perhaps the disappearance of the GitHub icon is due to its updating?).

Steps to Reproduce

1. Update to last nightly
2. Open something from top sites bar

Actual result:

Expected result:

List of my top sites and correct displaying of GitHub icon.

Reproduces how often:

N/A

Brave version (brave://version info)

Brave: 1.9.1 Chromium: 81.0.4044.83 (Official build) unknown (64-bit)
Version: 5718ca617723806b9aacfb41108a0d911d1bde74-refs/branch-heads/4044@{#853}
OS: Linux

Version/Channel Information:

• Q: Can you reproduce this issue with the nightly channel? A: Yes

Other Additional Information:

• Q: Does the issue resolve itself when disabling Brave Shields? A: No
• Q: Does the issue resolve itself when disabling Brave Rewards? A: No
• Q: Is the issue reproducible on the latest version of Chrome? A: Yes

[cezaraugusto]

Hi @congard, did you take any action before this bug happened like pinned/excluded/re-ordered top sites?

[cezaraugusto]

Also if you don't mind, could you send me (either in this thread or Twitter DM if you prefer, same username @cezaraugusto) your NTP localStorage file? Here's the steps:

1. Go to brave://newtab and open the developer tools (context menu -> inspect).
2. Find the console tab, click
3. Paste the following:
   3.1 JSON.parse(localStorage.getItem('new-tab-data')).pinnedTopSites
   3.2 JSON.parse(localStorage.getItem('new-tab-data')).ignoredTopSites
   3.3 JSON.parse(localStorage.getItem('grid-sites-data-v1')).gridSites
   3.4 JSON.parse(localStorage.getItem('grid-sites-data-v1')).topSites

Please note that we do not store this information and it's only available in your computer (specifically your new tab). I'm requesting it because your top sites data appear to be corrupted after the update and I need a broken profile to try to reproduce your issue. Thanks for reporting!

[congard]

Hi @cezaraugusto, I didn't do anything before this happened. Just updated the browser.
3.1. undefined
3.2. undefined
3.3.

3.4. undefined

[cezaraugusto]

Thanks @congard, with the data you shared I was able to reproduce and just opened a pull-request.

[kjozwiak]

Verification PASSED on macOS 10.15.4 x64 Catalina using the following build:

Brave | 1.8.86 Chromium: 81.0.4044.129 (Official Build) (64-bit)
-- | --
Revision | 3d71af9f5704a40b85806f4d08925db24605ba25-refs/branch-heads/4044@{#979}
OS | macOS Version 10.15.4 (Build 19E287)

Went through the cases outlined under https://github.com/brave/brave-core/pull/5173#issue-400312677 and https://github.com/brave/brave-core/pull/5173#issuecomment-617724800 x2 times to ensure everything was working as expected.

Populated several tiles on the NTP using 1.7.98 CR: 81.0.4044.113 as per the following:

Updated to 1.8.86 CR: 81.0.4044.129 and ensured that I didn't lose any tiles on the NTP:

Used the script from https://github.com/brave/brave-core/pull/5173#issue-400312677 and ensured that both https://translate.google.com and https://github.com/congard where added in the correct positions:

---

Verification passed on

Brave | 1.8.86 Chromium: 81.0.4044.129 (Official Build) (64-bit)
-- | --
Revision | 3d71af9f5704a40b85806f4d08925db24605ba25-refs/branch-heads/4044@{#979}
OS | Windows 10 OS Version 1803 (Build 17134.1006)

Went through the cases outlined under https://github.com/brave/brave-core/pull/5173#issue-400312677 and https://github.com/brave/brave-core/pull/5173#issuecomment-617724800 and ensure everything was working as expected.

Populated several tiles on the NTP using 1.7.98 CR: 81.0.4044.113 as per the following:

Updated to 1.8.86 CR: 81.0.4044.129 and ensured that I didn't lose any tiles on the NTP:

Used the script from https://github.com/brave/brave-core/pull/5173#issue-400312677 and ensured that both https://translate.google.com and https://github.com/congard where added in the correct positions:

• Launched duplicate pinned top tiles profile using 1.8.86 and ensured that there are no duplicate pinned top tiles when NTP is opened in 1.8.86, also verified new top tiles can be added and pinned in NTP.
• Populated 6 top tiles in 1.7.98 and pinned 3 sites in NTP and upgraded to 1.8.86 and ensured that top tiles are not lost also there are no duplicate pinned top tiles when NTP is opened
• Populated 6 top tiles in clean profile 1.8.86 and pinned 3 sites and bookmarked 3 sites and restarted the browser, browser restart did not lose any top tiles, and position of top tiles is retained and ensured that pinned top tiles cannot be excluded and position of the top tiles can be changed by drag and dropping the top tiles and bookmarks can be unbookmarked and top tiles can be excluded and restore all at once.

Verification passed on

Brave | 1.8.86 Chromium: 81.0.4044.129 (Official Build) (64-bit)
-- | --
Revision | 3d71af9f5704a40b85806f4d08925db24605ba25-refs/branch-heads/4044@{#979}
OS | Ubuntu 18.04 LTS

Upgraded from 1.7.98. Verified no duplicate top sites.
Before upgrade:

After upgrade

Verified test plan from https://github.com/brave/brave-core/pull/5173
Used the script to generate duplicate top sites.