Brave-browser: Failing browser test: BraveRewardsBrowserTest SplitProcessorAutoContribution

Created on 1 Apr 2020 · 11Comments · Source: brave/brave-browser

Description

20:13:31  [  FAILED  ] BraveRewardsBrowserTest.SplitProcessorAutoContribution, where TypeParam =  and GetParam() =  (8647 ms)
20:13:31  [507/507] BraveRewardsBrowserTest.SplitProcessorAutoContribution (8721 ms)
20:13:31  1 test failed:
20:13:31      BraveRewardsBrowserTest.SplitProcessorAutoContribution (../../brave/components/brave_rewards/browser/rewards_service_browsertest.cc:3111)

QNo dev-concern featurrewards release-noteexclude tests

Source

bsclifton

All 11 comments

Test was introduced with https://github.com/brave/brave-core/pull/5050 - however, CI was passing at the time it was merged. Something may have changed after this which broke the test

bsclifton on 1 Apr 2020

First PR that I see which has a failure (working backwards) is https://github.com/brave/brave-core/pull/5058. Not sure if this is the cause... but the PR before that (https://github.com/brave/brave-core/pull/5109) ran on macOS (which runs browser tests) and passed without issue

bsclifton on 1 Apr 2020

@bsclifton is this something that is failing all the time? As just one PR that I did yesterday was green, so I think this is intermittent

NejcZdovc on 1 Apr 2020

@NejcZdovc possibly intermittent - it has failed with the last few PRs though (started happening today). Would you be able to try on master?

bsclifton on 1 Apr 2020

Have https://github.com/brave/brave-core/pull/5129 running right now on the latest master, let's see what will happen. Trying locally as well

NejcZdovc on 1 Apr 2020

👍1

This one is all green, PR created couple of hours ago https://github.com/brave/brave-core/pull/5121. So for sure is intermittent

NejcZdovc on 1 Apr 2020

this test passes on my machine as well, but get some other failing tests. Issue logged here https://github.com/brave/brave-browser/issues/8958

NejcZdovc on 1 Apr 2020

👍1

should be fixed with https://github.com/brave/brave-core/pull/4114

NejcZdovc on 1 Apr 2020

@NejcZdovc could you please take a look and let us know if this issue requires manual QA? Issue seems to be for browser tests but would like to confirm. If no manual QA needed please add QA/No label. Thanks! cc @kjozwiak