Brave-browser: Make casing of settings titles / text consistent

Created on 23 Mar 2020  路  9Comments  路  Source: brave/brave-browser

Test plan

  1. Visit brave://settings on any OS (doesn't matter)
  2. Review changes called out at top of https://github.com/brave/brave-core/pull/5631

Description

the follow are all cases that don't follow sentence casing in brave://settings

- Side menu -> "Help Tips"
- Appearance -> Themes -> "Open Web Store"
- Appearance -> "Always show bookmarks on New Tab page"
- Appearance -> "Pressing Tab on a webpage"
- Shields -> "Look & Feel"
- Extensions -> "Web3 provider for using Dapps"
- Extensions -> "Private Window with Tor"
- Extensions -> Get more extensions -> "Open Web Store"
- Privacy and security -> "WebRTC IP Handling Policy"
- Privacy and security -> "Use Google Services for Push Messaging"

cc: @karenkliu @rebron

ODesktop QA Pass-Linux QA Pass-Win64 QA Pass-macOS QYes featursettings good first issue needs-text-change polish prioritP4 release-noteinclude

Most helpful comment

@jonathanKingston no worries - got me noticing https://github.com/brave/brave-core/pull/5631 which somehow got past the radar (so many PRs!). Saw that got approved- just needs a rebase. Will try to sort that out

All 9 comments

Hey, I would love to give this issue a try!

Just to double check, we expect the following changes on the brave://settings page:

| Text Before | Text After | Location |
|---|---|---|
| Help Tips | Help tips | Side menu under settings-menu |
| Open Web Store | Open web store | under Appearance section |
| Always show bookmarks on New Tab page | Always show bookmarks on new tab page | under Appearance section |
| Pressing Tab on a webpage highlights links, as well as form fields | Pressing tab on a webpage highlights links, as well as form fields | under Appearance section only on macOS |
| Look & Feel | Look & feel | under Shields section |
| Web3 provider for using Dapps | Web3 provider for using dapps | under Extensions section |
| Private Window with Tor | Private window with Tor | under Extensions section |
| Open Web Store | Open web store | description of Get more extensions under Extensions section |
| WebRTC IP Handling Policy | WebRTC IP handling policy | under Privacy and Security section |
| Use Google Services for Push Messaging | Use Google services for push messaging | under Privacy and Security section |

@edwardqiu Keep Dapps the same. Everything else looks good.

Hey, @rebron. Since this is my first time contributing here, it took me a while to get my dev environment set up.

I've made the changes here. I also tested all of them manually on Ubuntu 16.04, except for the following changes:
Appearance -> Themes -> "Open Web Store", because the text change is not reached because of this code block.
Appearance -> "Pressing Tab on a webpage", because this text change is also not reached because it is within this code block.

For the exceptions, would there be someone with macOS be able to checkout my branch and test it?

I've also noticed on Linux - there are a few more things that may not be following sentence casing. Would you like these things to be changed to follow sentence casing as well?

image
image
image
image

image
I noticed this in the mentioned text changes the & is being escaped in: Version 1.9.72 Chromium: 81.0.4044.138 (Official Build) (64-bit)

@jonathanKingston that's a pretty old version - I think we've fixed it since then. Can you please update Brave and report back if it's fixed?

Ah so it is :') thanks, I thought I was on the auto update path. thanks!

Confirmed, it's fine now. Sorry for disturbing!

@jonathanKingston no worries - got me noticing https://github.com/brave/brave-core/pull/5631 which somehow got past the radar (so many PRs!). Saw that got approved- just needs a rebase. Will try to sort that out

Verification passed on

Brave | 1.17.32 Chromium: 86.0.4240.80聽(Official Build)聽nightly聽(64-bit)
-- | --
Revision | 7ed88b53bda45a2d19efb4f8706dd6b6cad0d3af-refs/branch-heads/4240@{#1183}
OS | Ubuntu 18.04 LTS

Verified test plan from the description

Side menu -> "Help Tips" to "Help tips"
image

Appearance -> Themes -> "Open Web Store" to "Open web store"
Not available on Ubuntu 18.04. It has Classic on clean install

Appearance -> "Always show bookmarks on New Tab page" to "Always show bookmarks on New Tab page"
image

Appearance -> "Pressing Tab on a webpage" to "Press tab on a webpage"
Not available on Ubuntu 18.04

Shields -> "Look & Feel" to "Look & feel"
image

Extensions -> "Private Window with Tor" to "Private window with Tor"
image

Extensions -> Get more extensions -> "Open Web Store" to "Open web store"
image

Privacy and security -> "WebRTC IP Handling Policy" to "WebRTC IP handling policy"
image

Privacy and security -> "Use Google Services for Push Messaging" to "Use Google services for push messaging"
image

Logged https://github.com/brave/brave-browser/issues/12147 for missing translations


Verification passed on

Brave | 1.17.39 Chromium: 86.0.4240.99聽(Official Build)聽nightly聽(64-bit)
-- | --
Revision | 002668237e13d38aabd6d11c2d216dd22b736ff2-refs/branch-heads/4240@{#1229}
OS | Windows聽10 OS Version 1903 (Build 18362.1082)

  • Verified test plan from the description

Side menu -> Help Tips to Help tips
image

Appearance -> Themes -> Open Web Store to Open web store
image

Appearance -> Always show bookmarks on New Tab page to Always show bookmarks on new tab page
image

Shields -> Look & Feel to Look & feel
image

Extensions -> Private Window with Tor" to **Private window with Tor
image

Extensions -> Get more extensions -> Open Web Store to Open web store
image

Privacy and security -> WebRTC IP Handling Policy to WebRTC IP handling policy
image

Privacy and security -> Use Google Services for Push Messaging to Use Google services for push messaging
image


Verification PASSED on macOS 10.15.7 x64 using the following build:

Brave | 1.17.41 Chromium: 86.0.4240.99聽(Official Build)聽nightly聽(x86_64)
-- | --
Revision | 002668237e13d38aabd6d11c2d216dd22b736ff2-refs/branch-heads/4240@{#1229}
OS | macOS Version 10.15.7 (Build 19H2)

Side Menu | Appearance | Shields | Extensions | Privacy & Sec
-----------------|-------------------|---------------|------------------|--------------------|
Screen Shot 2020-10-19 at 11 06 31 PM | Screen Shot 2020-10-19 at 11 07 17 PM | Screen Shot 2020-10-19 at 11 11 37 PM | Screen Shot 2020-10-19 at 11 12 07 PM | Screen Shot 2020-10-19 at 11 13 48 PM

Was this page helpful?
0 / 5 - 0 ratings