Brave-browser: Hide Estimated Bandwidth Stat on NTP on desktop

Created on 14 Feb 2020 · 10Comments · Source: brave/brave-browser

Description

Hide Estimated Bandwidth stat on NTP for desktop. This stat will be used to replace HTTPS Upgrades on mobile but not on Desktop.

Actual result:

74498031-518f5480-4f05-11ea-8612-3d8ba9d085c3

Expected result:

Screen Shot 2020-02-14 at 12 55 20 PM

Version/Channel Information:

Can you reproduce this issue with the current release? No.
Can you reproduce this issue with the beta channel? No.
Can you reproduce this issue with the dev channel? No.
Can you reproduce this issue with the nightly channel? Yes. 1.6.x

QA Pass-Linux QA Pass-Win64 QA Pass-macOS QYes bug design featuruser-interface needs-discussion release-noteexclude

Source

rebron

Most helpful comment

If we remove for part of desktop, let's remove for all of desktop 😄 Will update issue title to reflect that

bsclifton on 3 Mar 2020

👍2

All 10 comments

Do we want to hide this? I can understand only wanting to see three. Anecdotal, but it's more meaningful to me personally than HTTPS upgrades 😄

Whatever the resolution, we'll need to make sure the gray (which is low contrast and almost disappears) is not used

bsclifton on 17 Feb 2020

If this was accidentally added into desktop and only belongs on Android, it should be removed from every channel. We shouldn't keep this visible on Nightly, Dev and Beta but not include it in the Release channel. If it doesn't belong on desktop, it needs to be removed everywhere.

kjozwiak on 3 Mar 2020

👍1

cc: @AndriusA Can we get the Bandwidth stat hidden? At minimum, we don't need this stat for release channel but not sure we need this for any other channels either as @kjozwiak mentioned. Sounds like you're all good for android-core though. cc: @anthonypkeane

rebron on 3 Mar 2020

@karenkliu can you please confirm a design for "Data Saved" on Android and post it here?
Thank you

anthonypkeane on 3 Mar 2020

If we remove for part of desktop, let's remove for all of desktop 😄 Will update issue title to reflect that

bsclifton on 3 Mar 2020

👍2

@karenkliu can you please confirm a design for "Data Saved" on Android and post it here?
Thank you

@anthonypkeane Android stats should look like this:
android data saved

karenkliu on 4 Mar 2020

cc: @AndriusA Can we get the Bandwidth stat hidden? At minimum, we don't need this stat for release channel but not sure we need this for any other channels either as @kjozwiak mentioned. Sounds like you're all good for android-core though. cc: @anthonypkeane

I'm not an impartial judge for whether to keep or remove - I obviously like it, but can remove if instructed

AndriusA on 4 Mar 2020

@AndriusA let's remove - but only for Desktop 😄 As Android Core is now using this code-base, you should be able to test for Android and only use in that instance

bsclifton on 4 Mar 2020

Removed OS/Androird label. @anthonypkeane please log a new issue for Android if it requires new design.

srirambv on 23 Mar 2020

Verification passed on

Brave | 1.7.70 Chromium: 80.0.3987.149 (Official Build) dev (64-bit)
-- | --
Revision | 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS | Ubuntu 18.04 LTS

Estimated Bandwidth stat on NTP is hidden

Verification passed on

Brave | 1.7.67 Chromium: 80.0.3987.149 (Official Build) beta (64-bit)
-- | --
Revision | 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS | Windows 10 OS Version 1803 (Build 17134.1006)

Estimated Bandwidth stat on NTP is hidden

Verified passed with

Brave | 1.7.71 Chromium: 80.0.3987.149 (Official Build) dev (64-bit)
-- | --
Revision | 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS | macOS Version 10.14.6 (Build 18G3020)