Brave-browser: Ads history will not be shown at all if there is an ad older than 7 days

[btlechowski]

Found when testing https://github.com/brave/brave-browser/issues/5863
We show 7 day ads history, if there is an ad older than 7 days, the whole ads history will not be shown. This is a regression in 1.3.x.

Important: This issue is not reproducible on 1.2.x, 1.4.x, 1.5.x
Important: Talked to @tmancey, and he said that this issue is fixed by https://github.com/brave/brave-browser/issues/6757

Steps to Reproduce

1. Clean install
2. Enable rewards
3. Open brave://rewards
4. Close Brave
5. Copy generated ads history file to User Data\Default\ads_service\ (ask @btlechowski for the file)
6. Launch Brave
7. Reload brave://rewards few times

Actual result:

7-day Ads History link is not shown at all on brave://rewards

Expected result:

7-day Ads History link is shown

Reproduces how often:

100% repro rate

Brave version (brave://version info)

Reproducible on

Brave | 1.3.91 Chromium: 79.0.3945.117 (Official Build) beta (64-bit)
-- | --
Revision | 04f0a055010adab4484f7497fbfdbf312c307f1d-refs/branch-heads/3945@{#1019}
OS | Windows 7 Service Pack 1 (Build 7601.24530)

Not reproducible on

Brave | 1.5.36 Chromium: 79.0.3945.117 (Official Build) nightly (64-bit)
-- | --
Revision | 04f0a055010adab4484f7497fbfdbf312c307f1d-refs/branch-heads/3945@{#1019}
OS | Windows 7 Service Pack 1 (Build 7601.24530)

Brave | 1.4.60 Chromium: 79.0.3945.117 (Official Build) dev (64-bit)
-- | --
Revision | 04f0a055010adab4484f7497fbfdbf312c307f1d-refs/branch-heads/3945@{#1019}
OS | Windows 7 Service Pack 1 (Build 7601.24530)

Version/Channel Information:

• Can you reproduce this issue with the current release? no
• Can you reproduce this issue with the beta channel? yes
• Can you reproduce this issue with the dev channel? no
• Can you reproduce this issue with the nightly channel? no

cc @brave/legacy_qa @rebron @tmancey @NejcZdovc

[tmancey]

Needs investigation to confirm if resolved by https://github.com/brave/brave-browser/issues/6757

[tmancey]

@btlechowski I have tested and all is working as expected for me, however as ads history requires that ads are initialized it can take a few seconds for ads to initialize before the link will be shown

Here is my test client.json:
client.json.zip

[btlechowski]

@tmancey I think the client.json you provided will always be a false-positive as the oldest ad shares the uuid with other ad and therefor will never be shown.

[tmancey]

@btlechowski Re-checking now, thanks

[tmancey]

@btlechowski Tested with: And works as expected on both 1.3 and 1.5. Can you please send your client.json to show the issue. Thanks

client.json.zip

1.5.x:

1.3.x (not sorted as we only implemented sorting on 1.4 and above.):

[btlechowski]

The issue only reproduces on 1.3.x.

I still see duplicate uuid in the new client.json

This is the file I use when the issue reproduces: client.zip
The file contains 8 ads, an ad is shown each day.
If I delete Test Ad 001 (ad from 8th day), the history is shown

[tmancey]

@LaurenWags @btlechowski I have now reproduced the issue on 1.3. A decision needs to be made if we should uplift both #7869 and #6757 to resolve this issue

[LaurenWags]

cc @kjozwiak @rebron re: https://github.com/brave/brave-browser/issues/7743#issuecomment-578671946

[LaurenWags]

Closing issue as it was not reproduced in 1.4.x milestone by @btlechowski (original reporter) and it will not be fixed for 1.3.x.

Additionally, we will have to test #8046 with this issue.

[btlechowski]

Verification passed on

Brave | 1.4.85 Chromium: 80.0.3987.87 (Official Build) beta (64-bit)
-- | --
Revision | 449cb163497b70dbf98d389f54e38e85d4c59b43-refs/branch-heads/3987@{#801}
OS | Windows 7 Service Pack 1 (Build 7601.24544)

Verified steps from the description. File used: client.zip
It has 1000 ads, 10 ads per day. Only most recent ads are shown.

Verification passed on

Brave | 1.4.84 Chromium: 80.0.3987.87 (Official Build) beta (64-bit)
-- | --
Revision | 449cb163497b70dbf98d389f54e38e85d4c59b43-refs/branch-heads/3987@{#801}
OS | Ubuntu 18.04 LTS

Verified steps from the description. File used: client.zip
It has 1000 ads, 10 ads per day. Only most recent ads are shown.

Verified passed with

Brave | 1.4.85 Chromium: 80.0.3987.87 (Official Build) beta (64-bit)
-- | --
Revision | 449cb163497b70dbf98d389f54e38e85d4c59b43-refs/branch-heads/3987@{#801}
OS | macOS Version 10.14.6 (Build 18G103)

• Verified using STR from description and file provided by @btlechowski
  Confirmed only the most recent ads are shown