Brave-browser: Monthly contributions (tips) and Auto Contribute are not listed on brave://rewards or panel summary

Created on 27 Dec 2019 · 14Comments · Source: brave/brave-browser

Description

Found while testing #6744
Monthly Tips are not listed under monthly contributions panel

Steps to Reproduce

Clean profile 1.3.75 staging env
Claim the UGP grants
Open https://duckduckgo.com/
Open the BR panel and set the monthly contributions for https://duckduckgo.com/
The monthly Tip isn't set and https://duckduckgo.com/ isn't displayed under monthly contributions panel.

Actual result:

Monthly Tips are not listed under monthly contributions panel
7526

Expected result:

Monthly Tips should be listed under monthly contributions panel

Reproduces how often:

Always

Brave version (brave://version info)

Brave | 1.3.75 Chromium: 79.0.3945.88 (Official Build) dev (64-bit)
-- | --
Revision | c2a58a36b9411c80829b4b154bfcab97e581f1f3-refs/branch-heads/3945@{#954}
OS | Windows 10 OS Version 1803 (Build 17134.1006)

Version/Channel Information:

Can you reproduce this issue with the current release? No
Can you reproduce this issue with the beta channel? No
Can you reproduce this issue with the dev channel? Yes
Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

Does the issue resolve itself when disabling Brave Shields? NA
Does the issue resolve itself when disabling Brave Rewards? NA
Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/legacy_qa @NejcZdovc @ryanml @rebron

QA Pass-Linux QA Pass-Win64 QA Pass-macOS QTest-Plan-Specified QYes bug featurrewards regression release-noteexclude

Source

GeetaSarvadnya

All 14 comments

Not reproducible on

Brave | 1.3.81 Chromium: 79.0.3945.88 (Official Build) beta (64-bit)
-- | --
Revision | c2a58a36b9411c80829b4b154bfcab97e581f1f3-refs/branch-heads/3945@{#954}
OS | Ubuntu 18.04 LTS

btlechowski on 4 Jan 2020

not reproduced on macOS

NejcZdovc on 4 Jan 2020

@GeetaSarvadnya Hi Geeta - can I just confirm what 'DDG' is in your steps? Presuming it was 'ddg.com' I tried to reproduce the above on Windows, but it worked fine;

Screenshot 2020-01-10 at 14 46 20

masparrow on 10 Jan 2020

@masparrow ddg is https://duckduckgo.com/

NejcZdovc on 10 Jan 2020

Cheers @NejcZdovc - just for completeness, I did a monthly tip for duckduckgo.com - works fine.

Nb. I was using; Version 1.5.24 Chromium: 79.0.3945.117 (Developer Build) (64-bit) (src/brave - c6d60490d12f0b94437532bae4eb1c246c8495a4)

Screenshot 2020-01-13 at 09 18 27

@GeetaSarvadnya Can you see if you can reproduce again, and if possible confirm if it is just Windows? Thanks!

masparrow on 13 Jan 2020

Could not reproduce on macOS using

Brave | 1.3.90 Chromium: 79.0.3945.117 (Official Build) beta (64-bit)
-- | --
Revision | 04f0a055010adab4484f7497fbfdbf312c307f1d-refs/branch-heads/3945@{#1019}
OS | macOS Version 10.14.6 (Build 18G103)

@GeetaSarvadnya how did you fund your wallet? you don't specify in the steps if you restored an old wallet or claimed a staging UGP grant. not sure if that makes a difference.

LaurenWags on 13 Jan 2020

@LaurenWags I have funded the wallet by accepting the UGP grants. I am going to edit the STR and make steps clear. Thanks!

GeetaSarvadnya on 14 Jan 2020

👍1

@masparrow Issue is still reproducible. Just verified it on latest beta channel 1.3.91. Please find the gif below:
7526

GeetaSarvadnya on 14 Jan 2020

Reproduced on macOS (see https://github.com/brave/brave-browser/issues/7709#issuecomment-574235189) using steps from https://github.com/brave/brave-browser/issues/7709#issuecomment-574223737

fyi @masparrow in case this additional information helps
cc @kjozwiak @rebron for consideration for the 1.3.x release

LaurenWags on 14 Jan 2020

Also experiencing this with one time tips using

Brave | 1.3.94 Chromium: 79.0.3945.117 (Official Build) beta (64-bit)
-- | --
Revision | 04f0a055010adab4484f7497fbfdbf312c307f1d-refs/branch-heads/3945@{#1019}
OS | macOS Version 10.14.6 (Build 18G103)

My wallet balance decreases but the tip isn't shown on brave://rewards Tips panel, wallet summary, or when I click on the BAT logo to show the summary.

LaurenWags on 17 Jan 2020

I finally managed to reproduce this one Win 10 x64. Once I reproduced the above once on the Win 10 x64 machine, it started occurring every single time with new profiles. Example:

Attached publisher_info_db.zip which belonged to this particular profile.

panelsIssue

Reproduced the above issue using the following build:

Brave | 1.3.97 Chromium: 79.0.3945.130 (Official Build) beta (64-bit)
--- | ---
Revision | e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS | Windows 10 OS Version 1909 (Build 18363.592)

However, I'm still having a hard time reproducing this on macOS but sounds like @LaurenWags ran into it via https://github.com/brave/brave-browser/issues/7526#issuecomment-575794413.

kjozwiak on 21 Jan 2020

Verified as fixed by the PR https://github.com/brave/brave-core/pull/4372 - @LaurenWags recommend this is regression tested against that PR (or nightly once that PR is merged).

masparrow on 22 Jan 2020

👍1

Retested on Nightly extensively while checking https://github.com/brave/brave-core/pull/4399#issuecomment-577823383 and https://github.com/brave/brave-core/pull/4372#issuecomment-577908068 and could not reproduce. Moving to 1.3.x milestone to be retested after these PRs are uplifted. Adding QA/Blocked label for now as well.

Brave | 1.5.53 Chromium: 79.0.3945.130 (Official Build) nightly (64-bit)
-- | --
Revision | e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS | macOS Version 10.14.6 (Build 18G103)

LaurenWags on 24 Jan 2020

Verified passed with

Brave | 1.3.106 Chromium: 79.0.3945.130 (Official Build) beta (64-bit)
-- | --
Revision | e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS | macOS Version 10.14.6 (Build 18G103)

Verified 1 time tip, recurring tip, and AC using previously self-funded anon wallet:
Verified 1 time tip, recurring tip, and AC using anon wallet funded via UGP (virtual) grant:
Verified 1 time tip, recurring tip, and AC using KYC'd user wallet:

Verification passed on

Brave | 1.3.107 Chromium: 79.0.3945.130 (Official Build) beta (64-bit)
-- | --
Revision | e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS | Windows 10 OS Version 1803 (Build 17134.1006)

Verified the STR from the description
Verified the test plan from https://github.com/brave/brave-core/pull/4372
Logged https://github.com/brave/brave-browser/issues/8019
Verified Monthly tips and one-time tips recorded in the summary and panel using wallet funded via UGP (virtual) grant:
AC went through and notification displayed as expected using user funded KYC'd wallet
Verified 1-time tip, recurring tip, and AC using KYC'd user wallet:

Verification passed on

Brave | 1.3.108 Chromium: 79.0.3945.130 (Official Build) beta (64-bit)
-- | --
Revision | e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS | Ubuntu 18.04 LTS

Verified the STR from the description
Verified the test plan from https://github.com/brave/brave-core/pull/4372
Verified Monthly tips and one-time tips recorded in the summary and panel using wallet funded via UGP (virtual) grant:
Verified 1-time tip, recurring tip, and AC using KYC'd user wallet: