Brave-browser: BAT Points follow-up to #6480 - Changes for Japan
Two changes that need to make it for the BAT Points fix;
a) All areas where we have text Tokens, needs to replaced with Points (search and replace)
b) Any BAT designation (tipping panel., etc.) needs to be replaced with BAP (Basic Attention Points)
see image below for b) ----
As example the Tip values in the panel would say 1.0 BAP, 5.0 BAP, and 10.0 BAP respectively
cc @jsecretan @NejcZdovc
mandar-brave
All 5 comments
See spec doc for more details
mattmcalister
on 29 Oct 2019
Running through https://github.com/brave/brave-core/pull/3751 before approving the PR into 0.72.x and 0.71.x and noticed the following screens/areas using BAT as @mandar-brave mentioned above. Adding examples so it's easier to QA once this lands in Nightly and is ready for QA:
Tipping banner:
Not enough funds during tipping banner:
Confirmation banner once tip goes through:
Confirmation banner once monthly tip has been set:
Ads panel:
Auto-contribution panel:
Tipping panel under brave://rewards:
Monthly contribution tipping panel:
Join Rewards panel:
Pending Contributions:
Auto-Contribution Settings:
Contribution Notification:
Grant Notification:
UGP grant confirmation:
kjozwiak
on 30 Oct 2019
All the issues mentioned in the https://github.com/brave/brave-browser/issues/6654#issuecomment-548078955 are reproduced in windows 10 x64 -0.71.111
GeetaSarvadnya
on 4 Nov 2019
Fixed in 0.71.x with https://github.com/brave/brave-core/pull/3884
bsclifton
on 8 Nov 2019
Verification passed on
Brave | 0.71.114 Chromium: 78.0.3904.97聽(Official Build)聽(64-bit)
-- | --
Revision | 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS | Windows聽10 OS Version 1803 (Build 17134.1006)
- Verified the test plan from https://github.com/brave/brave-core/pull/3884
Tipping Banner
No enough funds in tipping banner
Confirmation banner once tip goes through
Confirmation banner once the monthly tip has been set
Ads panel
Auto-contribution panel
Tipping panel under brave://rewards
Monthly contribution tipping panel
Join Rewards panel
Pending Contributions
Auto-Contribution Settings
Contribution Notification
Grant Notification
UGP grant confirmation
Verification PASSED on macOS 10.15.1 x64 using the following build:
Brave | 0.71.114 Chromium: 78.0.3904.97聽(Official Build)聽(64-bit)
-- | --
Revision | 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS | macOS Version 10.15.1 (Build 19B88)
- Went through and verified https://github.com/brave/brave-browser/issues/6654#issuecomment-548078955
- Went through the BAP specification and ensured everything was changed as per the specification
Verification passed on
Brave | 0.71.114 Chromium: 78.0.3904.97聽(Official Build)聽(64-bit)
-- | --
Revision | 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS | Ubuntu 18.04 LTS
- Went through and verified https://github.com/brave/brave-browser/issues/6654#issuecomment-548078955
- Went through the BAP specification and ensured everything was changed as per the specification
GeetaSarvadnya
on 11 Nov 2019
Related issues
jonathansampson
路
3Comments
GeetaSarvadnya
路
3Comments
hollons
路
3Comments
kerry-perret
路
3Comments
pitsi
路
3Comments
Most helpful comment
Running through https://github.com/brave/brave-core/pull/3751 before approving the PR into
0.72.xand0.71.xand noticed the following screens/areas using BAT as @mandar-brave mentioned above. Adding examples so it's easier to QA once this lands in Nightly and is ready for QA:Tipping banner:Not enough funds during tipping banner:Confirmation banner once tip goes through:Confirmation banner once monthly tip has been set:Ads panel:Auto-contribution panel:Tipping panel under brave://rewards:Monthly contribution tipping panel:Join Rewards panel:Pending Contributions:Auto-Contribution Settings:Contribution Notification:Grant Notification:UGP grant confirmation: