Brave-browser: 'Relaunch' button re-toggles 'Push Messaging' feature before relaunching

[LesterCovax]

Test plan

See https://github.com/brave/brave-core/pull/4042

Description

After enabling or disabling Use Google Services for Push Messaging, clicking the Relaunch button prompt toggles the setting back to its original state before relaunching the browser. After the browser restarts, the setting is in its original state. Running chrome://restart in a separate tab after toggling the setting circumvents the issue.

Steps to Reproduce

1. chrome://settings/privacy
2. Toggle Use Google Services for Push Messaging
3. Click Relaunch

Actual result:

The setting is visibly toggled back to its original state when Relaunch is clicked, followed by the browser restarting.

Toggling on...

Toggling off...

Expected result:

The setting should maintain its current state when Relaunch is clicked.

The Dream...

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave: 0.72.110 Chromium: 78.0.3904.70 (Official Build) dev (64-bit)
Revision: edb9c9f3de0247fd912a77b7f6cae7447f6d3ad5-refs/branch-heads/3904@{#800}
OS: Windows 10 OS Version 1903 (Build 19002.1)

Version/Channel Information:

The setting is not available in release/beta channels currently and I don't have nightly installed.

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? N/A
• Does the issue resolve itself when disabling Brave Rewards? N/A
• Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

:no_mouth:

[srirambv]

Awesome GIFS. :clap:

[bsclifton]

@jumde could you take a look at this?

[jumde]

Thanks for the report @LesterCovax, investigating this.

[btlechowski]

Verification passed on

Brave | 1.2.41 Chromium: 79.0.3945.88 (Official Build) (64-bit)
-- | --
Revision | c2a58a36b9411c80829b4b154bfcab97e581f1f3-refs/branch-heads/3945@{#954}
OS | Ubuntu 18.04 LTS

Verified test plan from https://github.com/brave/brave-core/pull/4042

Verification PASSED on macOS 10.15.2 x64 using the following build:

Brave | 1.2.41 Chromium: 79.0.3945.88 (Official Build) (64-bit)
-- | --
Revision | c2a58a36b9411c80829b4b154bfcab97e581f1f3-refs/branch-heads/3945@{#954}
OS | macOS Version 10.15.2 (Build 19C57)

• Verified the test plan outlined under https://github.com/brave/brave-core/pull/4042
• ensured that clicking on the notification opened a new tab pointing to https://developers.google.com/web/fundamentals
• ensured that clicking on Close dismissed the notification without opening a new tab
• ensured that clicking on Settings opened brave://settings/content/notifications
• ensured removing the permission for https://gauntface.github.io under brave://settings/content/notifications also disabled notifications when refreshing https://gauntface.github.io/simple-push-demo/
• ensured that disabling Push Messaging from brave://settings/privacy also disabled notifications when refreshing https://gauntface.github.io/simple-push-demo/.
• ensured that clicking on Enable Push Notifications didn't work under https://gauntface.github.io/simple-push-demo/ when and produced Ooops a Problem Occurred when Push Messaging was disabled via brave://settings/privacy

Verification passed on

Brave | 1.2.41 Chromium: 79.0.3945.88 (Official Build) (64-bit)
-- | --
Revision | c2a58a36b9411c80829b4b154bfcab97e581f1f3-refs/branch-heads/3945@{#954}
OS | Windows 10 OS Version 1803 (Build 17134.1006)

• Verified test plan from https://github.com/brave/brave-core/pull/4042