Brave-browser: adblocker doesn't work on golem.de when not disabling scripts

Created on 5 Oct 2019  路  7Comments  路  Source: brave/brave-browser
  1. adblocker is activated
  2. scripts are allowed.
  3. golem.de looks like this:
    image
    But there shouldn't be any adverts.

I am using Brave on Windows 10: Version 0.69.132 Chromium: 77.0.3865.90 (Official Build) (64-bit)

closefixed-by-component-update featurshieldadblock
Source
picture szaimen

Most helpful comment

Just waiting on review :)

picture ryanbr on 6 Oct 2019
👍2 🎉1

All 7 comments

cc: @ryanbr

srirambv picture srirambv on 6 Oct 2019

Just waiting on review :)

ryanbr picture ryanbr on 6 Oct 2019
👍2 🎉1

@ryanbr If you need a review, maybe you could guide me how to review this?
I am no developer unfortunately and don't know where to start and what I need to do to test your PR :(

szaimen picture szaimen on 7 Oct 2019

I tried golem.de again with cosmetic blocking enabled and it still shows first party ads. Is there something I am missing?

szaimen picture szaimen on 16 Feb 2020

@szaimen I don't think first party ads are removed

cc: @antonok-edm @snyderp for confirmation

It should be possible to block these though using the brave://adblock page and adding the selector

bsclifton picture bsclifton on 17 Feb 2020

https://github.com/brave/adblock-lists/pull/329 Should fix this.

ryanbr picture ryanbr on 17 Feb 2020

Seems to be working great- going to close 馃槃 Let's re-open if there is still a problem

bsclifton picture bsclifton on 14 May 2020
Was this page helpful?
0 / 5 - 0 ratings

Related issues

bsclifton picture bsclifton  路  3Comments
hollons picture hollons  路  3Comments
simonhong picture simonhong  路  3Comments
kerry-perret picture kerry-perret  路  3Comments
qingxiang-jia picture qingxiang-jia  路  3Comments