Brave-browser: Typescript (.ts and .tsx) files have no syntax highlighting when opened in the dev tools Sources tab

Created on 11 Aug 2019  路  8Comments  路  Source: brave/brave-browser

Description


I'm developing a website using Typescript. When I open the dev tools, go to the Sources tab and click any .ts or .tsx files, there is no syntax highlighting.

Steps to Reproduce

Requires node/npm to be installed

  1. Run npx create-react-app myappname --typescript
  2. cd myappname
  3. npm start
  4. Open localhost:3000 in brave
  5. Go to DevTools > Sources tab
  6. Open index.tsx or any other ts/tsx file

Actual result:


No syntax highlighting although the debugger still works

image

Expected result:

Syntax highlighting, shown in Chrome

image

Reproduces how often:


Easily reproduced. I've never seen it working correctly

Brave version (brave://version info)

Brave | 0.67.124 Chromium: 76.0.3809.100聽(Official Build)聽(64-bit)
-- | --
Revision | ed9d447d30203dc5069e540f05079e493fc1c132-refs/branch-heads/3809@{#990}
OS | Windows聽10 OS Version 1809 (Build 17763.615)

Chrome for comparison:

Google Chrome | 76.0.3809.100聽(Official Build)聽(64-bit)聽(cohort: Stable)
-- | --
Revision | ed9d447d30203dc5069e540f05079e493fc1c132-refs/branch-heads/3809@{#990}
OS | Windows聽10 OS Version 1809 (Build 17763.615)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Not tried
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Not tried

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? No
  • Does the issue resolve itself when disabling Brave Rewards? No
  • Is the issue reproducible on the latest version of Chrome? No

Miscellaneous Information:

QNo featurdev-tools prioritP3 release-noteinclude

Most helpful comment

@bsclifton thanks for the update! It works for me in nightly after enabling remote debugging and browser restart.

All 8 comments

Possibly blocking a script from Google that's doing the styling.

But I would think that whatever's responsible for providing syntax highlighting for files in the devtools would be shipped with Brave? It doesn't seem like something an external script would need to be downloaded for

Bump.

That would be great

This stopped me as a web developer to use brave as main browser. Three times =(

This may be fixed now; with Nightly (and it'll work its way down through channels), you can enable remote debugging under brave://settings/privacy. When this is enabled, it should fetch sources

@ksbrar @rguillaume @alexichepura and others: can you please try Nightly and confirm it works? (with Remote Debugging enabled?)

@bsclifton thanks for the update! It works for me in nightly after enabling remote debugging and browser restart.

Closing as this is fixed with https://github.com/brave/brave-core/pull/4044

Thanks for the confirmation, @alexichepura! 馃槃

Was this page helpful?
0 / 5 - 0 ratings