Brave-browser: WebTorrent: UI Redesign

Created on 26 Jul 2019  Â·  4Comments  Â·  Source: brave/brave-browser

This issue is for discussing a UI redesign for the WebTorrent extension. @rossmoody did some amazing work on some mockups in this comment: https://github.com/brave/brave-core/pull/3003#issuecomment-515267754 which are a great starting point.

Goals

  • Modernize and cleanup the design
  • Show better indicators of download progress (including individual file progress)
  • Offer "Save All Files..." functionality (https://github.com/brave/brave-browser/issues/1230)
  • Indicate which files are viewable/playable immediately in the browser (play icon?)
  • Any other goals?
design featurwebtorrent

Most helpful comment

Depending how much we want to break this down per issues (and I would defer but I'd like to help where i can) I think if we use the following screens as a baseline then maybe something like:

  • [ ] Refine UI structure and style (larger initial restructure with tbd subtasks like new components and sunset Brave UI dependencies)
  • [ ] Component states, responsiveness and accessibility refinement
  • [ ] Set up theming variables
  • [ ] Hook up theming to Brave theme provider
  • [ ] Show better indicators of download progress (including individual file progress)
  • [ ] Offer "Save All Files..." functionality (#1230)
  • [ ] Indicate which files are viewable/playable immediately in the browser (play icon?)
  • [ ] Open in new tab button (for media of tbd type)
  • [ ] Indicate a disabled version of media buttons until content is ready

image

image

All 4 comments

Depending how much we want to break this down per issues (and I would defer but I'd like to help where i can) I think if we use the following screens as a baseline then maybe something like:

  • [ ] Refine UI structure and style (larger initial restructure with tbd subtasks like new components and sunset Brave UI dependencies)
  • [ ] Component states, responsiveness and accessibility refinement
  • [ ] Set up theming variables
  • [ ] Hook up theming to Brave theme provider
  • [ ] Show better indicators of download progress (including individual file progress)
  • [ ] Offer "Save All Files..." functionality (#1230)
  • [ ] Indicate which files are viewable/playable immediately in the browser (play icon?)
  • [ ] Open in new tab button (for media of tbd type)
  • [ ] Indicate a disabled version of media buttons until content is ready

image

image

I suspect long file names will be the usual and we'll see wrapping more often than not. Maybe wider on the filename? Design looks really nice.

that's so true. maybe some type of character limit and then institute truncation? could be a nice accessibility feature to fill the title attr of the truncated text with some type of automation.

Screen Shot 2019-07-29 at 5 01 21 PM

I implemented the design in HTML + CSS ✨ It looks great!

Click to zoom. 🔎

Screen Shot 2019-08-07 at 4 10 59 PM
Screen Shot 2019-08-07 at 4 10 47 PM

Was this page helpful?
0 / 5 - 0 ratings

Related issues

traffisco picture traffisco  Â·  3Comments

kjozwiak picture kjozwiak  Â·  3Comments

simonhong picture simonhong  Â·  3Comments

AlexCombas picture AlexCombas  Â·  3Comments

qingxiang-jia picture qingxiang-jia  Â·  3Comments