Brave-browser: Implement cosmetic blocking [tracking]

[pes10k]

Notes for QA (edit by @bsclifton)

• In 1.5, Cosmetic filtering needs to be enabled via brave://flags/#brave-adblock-cosmetic-filtering
• It wasn't until 1.6 that this setting's default value was changed from false to true (see this PR for more info)
• https://github.com/brave/brave-core/pull/3303 (original implementation) only mentions automated tests, does not feature a test plan

Test Plan

In 1.5:
First, enable cosmetic filtering via brave://flags/#brave-adblock-cosmetic-filtering

Then, in both 1.5 and 1.6:
Navigate to https://enpt.dict.cc in a new tab
Ensure there is no large square whitespace under the word "Advertisement" in the center of the page (by the "dict.cc Dicionário Inglês-Português: Portuguese-English and Multilingual Dictionary" header)

Description

Would be great to support EasyList and similar cosmetic filter rules. Much of this work has already been done in https://github.com/brave/adblock-rust. This issue is a tracking issue to keep track of all the branches and changes needed across multiple projects to land this in brave-browser.

[antonok-edm]

Relevant tracking issue in adblock-rust: https://github.com/brave/adblock-rust/issues/38

[antonok-edm]

Relevant tracking issue in adblock-rust-ffi: https://github.com/brave/adblock-rust-ffi/issues/3

[bsclifton]

When another fix is attempted, we'll want to link to test plan if manual QA is required. If not and everything is covered by automation, we can change label to QA/No

[szaimen]

So I have enabled the cosmetic filtering option over brave://flags. But as soon as I visit a website, brave nightly crashes on Windows 10. I also cannot find any additional option concerning cosmetic filtering in the brave settings after a relaunch after I enabled the flag.

Is there something I have missed to enable this option?

[antonok-edm]

@szaimen crashes on Windows should be fixed as of https://github.com/brave/brave-core/pull/4540.

Currently there are no additional settings regarding cosmetic filtering; this work supports the cosmetic filters that will soon be shipped from our filter lists.

The feature flag will be on by default with https://github.com/brave/brave-core/pull/4511.

[LaurenWags]

Adding QA/Blocked label for now.

Per discussion with @rebron not all PRs needed for this are currently in 1.5.x so this needs some sorting before QA can test.

[LaurenWags]

Verified passed with

Brave | 1.5.109 Chromium: 80.0.3987.132 (Official Build) beta (64-bit)
-- | --
Revision | fcea73228632975e052eb90fcf6cd1752d3b42b4-refs/branch-heads/3987@{#974}
OS | macOS Version 10.14.6 (Build 18G3020)

• Verified test plan from description

https://enpt.dict.cc/ without cosmetic blocking flag enabled:

https://enpt.dict.cc/ after cosmetic blocking flag enabled:

• Also did a spot check of some other sites, no majorly noticeable issues. Display of some sites, such as buzzfeed.com improved.

buzzfeed.com without cosmetic blocking flag enabled:

buzzfeed.com with cosmetic blocking flag enabled:

Verification passed on

Brave | 1.5.109 Chromium: 80.0.3987.132 (Official Build) beta (64-bit)
-- | --
Revision | fcea73228632975e052eb90fcf6cd1752d3b42b4-refs/branch-heads/3987@{#974}
OS | Windows 10 OS Version 1803 (Build 17134.1006)

• Verified test plan from the description
  https://enpt.dict.cc/ without cosmetic blocking flag enabled:
  

https://enpt.dict.cc/ after cosmetic blocking flag enabled:

buzzfeed.com without cosmetic blocking flag enabled:

buzzfeed.com with cosmetic blocking flag enabled:

Verification passed on

Brave | 1.5.111 Chromium: 80.0.3987.132 (Official Build) (64-bit)
-- | --
Revision | fcea73228632975e052eb90fcf6cd1752d3b42b4-refs/branch-heads/3987@{#974}
OS | Ubuntu 18.04 LTS

disabled

enabled