Brave-browser: Rewards popup doesn't show on Nightly

Created on 23 Jul 2019  路  13Comments  路  Source: brave/brave-browser

Description


Rewards popup doesn't show on Nightly

Steps to Reproduce

  1. Install an older version of nightly
  2. Update to the current nightly public build (0.69.77)
  3. Click on rewards panel, doesn't show the panel just a small box

Actual result:


Screenshot from 2019-07-23 09-42-36

Expected result:

Panel should be shown

Reproduces how often:


Easy on my machine

Brave version (brave://version info)

Brave | 0.69.77 Chromium: 76.0.3809.62聽(Official Build)聽nightly聽(64-bit)
-- | --
Revision | 7b77856b3aa34d72f246d12340fc1ded8b2c0e83-refs/branch-heads/3809@{#798}
OS | Linux

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? No
  • Can you reproduce this issue with the dev channel? No
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? No
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:


Close and restart browser doesn't fix the issue

QA Pass-Linux QA Pass-Win64 QA Pass-macOS QYes bug featurrewards release-noteexclude releasblocking
Source
picture srirambv
👍1

All 13 comments

This is intermittently reproducible when you have a notification on the BAT logo.
Steps I used to reproduce:

  1. Install 0.69.47 with staging variables set
  2. Enable rewards.
  3. Restore a wallet that will produce a notification (ad grant, back up wallet, insufficient funds, etc).
  4. Don't dismiss notification.
  5. Upgrade to 0.69.77.
  6. Click on BAT logo --> panel doesn't open, see white box instead.
    Screen Shot 2019-07-23 at 10 19 21 AM
LaurenWags picture LaurenWags on 23 Jul 2019
👍1

I have seen this issue once in Beta channel 0.68.114. Steps which I have followed to reproduce the issue:

  1. clean profile 0.68.113 (Staging env, reconcile interval was set to 2 mins)
  2. claim grants
  3. added few sites to a-c table (verified+non verified)
  4. kept browser idle for a couple of hours
  5. got 29 counter-notification on BAT logo
  6. upgraded profile to 0.68.114
  7. after upgrade click on BAT logo did not open up the rewards panel

image

GeetaSarvadnya picture GeetaSarvadnya on 31 Jul 2019

@NejcZdovc we've got a report of this in from community as well: https://community.brave.com/t/unable-to-open-brave-rewards-with-triangle-icon-in-internet-search-box/75914

This has now hit beta channel and will likely be affecting more users.

cc @rebron @alexwykoff

LaurenWags picture LaurenWags on 16 Aug 2019

+1 from community: https://community.brave.com/t/problem-mounting-rewards-panel/76917

LaurenWags picture LaurenWags on 23 Aug 2019

Verification passed on

Brave | 0.69.115 Chromium: 76.0.3809.100聽(Official Build)聽beta聽(64-bit)
-- | --
Revision | ed9d447d30203dc5069e540f05079e493fc1c132-refs/branch-heads/3809@{#990}
OS | Windows聽10 OS Version 1803 (Build 17134.523)

Verification passed on

Brave | 0.69.116 Chromium: 76.0.3809.100聽(Official Build)聽beta聽(64-bit)
-- | --
Revision | ed9d447d30203dc5069e540f05079e493fc1c132-refs/branch-heads/3809@{#990}
OS | Ubuntu 18.04 LTS

Verified passed with

Brave | 0.69.124 Chromium: 76.0.3809.132聽(Official Build)聽(64-bit)
-- | --
Revision | fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS | Mac OS X

GeetaSarvadnya picture GeetaSarvadnya on 25 Aug 2019

I'm getting this issue on version 0.68.132 / Windows 10

devcshort picture devcshort on 29 Aug 2019

@devcshort Can you inspect that window, and see what the console says? I suspect there's a problem calling .toString off an object somewhere. Would love your assistance in confirming.

jonathansampson picture jonathansampson on 2 Sep 2019

@jonathansampson
image

devcshort picture devcshort on 2 Sep 2019

@devcshort Thank you. I suspect you're seeing the same issue as another user. I just did a quick debugging session with them, and we found that l.total was undefined in the render method. I've shared this with the team, and we'll be working on a fix for 0.69.x.

image

jonathansampson picture jonathansampson on 2 Sep 2019

See https://github.com/brave/brave-browser/issues/5987#issuecomment-530364300 for ways to trigger white box from panel on 0.68.134.

LaurenWags picture LaurenWags on 11 Sep 2019

I am able to reproduce the scenarios mentioned in the comments https://github.com/brave/brave-browser/issues/5987#issuecomment-530364300 and https://github.com/brave/brave-browser/issues/5987#issuecomment-530437455 in brave version 0.68.135

GeetaSarvadnya picture GeetaSarvadnya on 12 Sep 2019

Reproduced on

Brave | 0.68.135 Chromium: 77.0.3865.75聽(Official Build)聽(64-bit)
-- | --
Revision | 201e747d032611c5f2785cae06e894cf85be7f8a-refs/branch-heads/3865@{#776}
OS | Ubuntu 18.04 LTS

image

btlechowski picture btlechowski on 13 Sep 2019

Verification passed on

Brave | 0.68.138 Chromium: 77.0.3865.75聽(Official Build)聽(64-bit)
-- | --
Revision | 201e747d032611c5f2785cae06e894cf85be7f8a-refs/branch-heads/3865@{#776}
OS | Windows聽10 OS Version 1803 (Build 17134.1006)

Verification passed on

Brave | 0.68.138 Chromium: 77.0.3865.75聽(Official Build)聽(64-bit)
-- | --
Revision | 201e747d032611c5f2785cae06e894cf85be7f8a-refs/branch-heads/3865@{#776}
OS | Ubuntu 18.04 LTS

Verification PASSED on macOS 10.14.6 x64 using the following build:

Brave | 0.68.138 Chromium: 77.0.3865.75聽(Official Build)聽(64-bit)
-- | --
Revision | 201e747d032611c5f2785cae06e894cf85be7f8a-refs/branch-heads/3865@{#776}
OS | macOS Version 10.14.6 (Build 18G95)

GeetaSarvadnya picture GeetaSarvadnya on 16 Sep 2019
🎉1
Was this page helpful?
0 / 5 - 0 ratings

Related issues

traffisco picture traffisco  路  3Comments
AlexeyBarabash picture AlexeyBarabash  路  3Comments
jonathansampson picture jonathansampson  路  3Comments
GeetaSarvadnya picture GeetaSarvadnya  路  3Comments
fmarier picture fmarier  路  3Comments