Brave-browser: Have a "hold to actually close" keyboard shortcut for pinned tabs

Created on 18 Jun 2019 · 8Comments · Source: brave/brave-browser

Description

Currently, pinned tabs can be closed with Ctrl+W / Cmd+W, and we've clarified this is the intended behavior.

A Chrome user recently suggested that we could have a "Hold X to close", similar to the Chrome/Chromium default behavior for Ctrl+Q/Cmd+Q for quit. It would look something like this:

Steps to Reproduce

Fresh profile
Visit a site
Right click tab, pick Pin Tab
Go into pinned tab
Hit Ctrl+W or Cmd+W

Actual result:

Pinned tab closes ☹️

Expected result:

User should have to hold shortcut to close

Reproduces how often:

100%

Brave version (brave://version info)

Brave | 0.68.56 Chromium: 75.0.3770.90 (Official Build) nightly(64-bit)
-- | --
Revision | a6dcaf7e3ec6f70a194cc25e8149475c6590e025-refs/branch-heads/3770@{#1003}
OS | Mac OS X

featurpinned-tabs prioritP5 suggestion

Source

bsclifton

👍8

Most helpful comment

https://github.com/brave/brave-browser/issues/4988#issue-458162978
Approach to solve inadvertently closing pinned tabs via ignoring CMD + W pref, might be a good way to go to instead of a warning.

rebron on 5 Jul 2019

👍2

All 8 comments

https://github.com/brave/brave-browser/issues/4988#issue-458162978
Approach to solve inadvertently closing pinned tabs via ignoring CMD + W pref, might be a good way to go to instead of a warning.

rebron on 5 Jul 2019

👍2

cc: @rossmoody

rebron on 5 Jul 2019

+1 from Community https://community.brave.com/t/possibly-quick-ux-improvement-for-pinned-tabs/99549?u=eljuno

eljuno on 24 Dec 2019

👍1

+1 from me - a great idea that would be very helpful!

ibwoo on 31 Mar 2020

+1. It gets little annoying when a pinned tab gets closed accidentally. Would be a very helpful UX improvement.

yuujay on 17 May 2020

👍1

+1 from me yes please

iQuery-001 on 28 May 2020

👍1

yigitkonur on 1 Jun 2020

👍1

Much prefer the preference option. Often pinned tabs are closed when you spam/hold Cmd+W so having a message would probably be ineffective. What exactly is the point of pinning of they are so easy to close?

Someone suggested restoring the tab, but if you're like me and have a mix open on SoundCloud or whatever, it doesn't restore the playback.