Brave-browser: RelChannel Browser cannot join sync chain with Beta/Dev browsers

Created on 1 Jun 2019 · 12Comments · Source: brave/brave-browser

Description

When creating a sync-chain with android, desktop-dev and desktop-beta browsers, the desktop-rel browser cannot join the chain. Attempting to add it just results in a no action when clicking "Confirm sync Code". Only way to dismiss the dialog is to click "Cancel"

Steps to Reproduce

Install Dev channel of Brave.
Start a sync channel with brave-dev.
Install Brave on Android.
Add android to sync channel.
Install Beta channel of Brave.
Add brave-beta to the sync channel.
Install Release channel of Brave
Add brave-rel to sync channel.
Observe that Sync Code dialog won't dismiss after entering code.

Actual result:

Clicking confirmation does not dismiss dialog

Expected result:

I expect the behavior to either produce an error, or accept the code and dismiss the dialog.

Reproduces how often:

Reproduces every time in the desktop-rel browser, and not at all in desktop-beta or desktop-dev browsers

Brave version (brave://version info)

Brave 0.64.77 Chromium: 74.0.3729.169 (Official Build) (64-bit)
Revision 78e4f8db3ce38f6c26cf56eed7ae9b331fc67ada-refs/branch-heads/3729@{#1013}

Version/Channel Information:

Can you reproduce this issue with the current release? Yes
Can you reproduce this issue with the beta channel? No
Can you reproduce this issue with the dev channel? No
Can you reproduce this issue with the nightly channel? Unknown

Other Additional Information:

Does the issue resolve itself when disabling Brave Shields? No
Does the issue resolve itself when disabling Brave Rewards? No
Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

Perhaps this is related to the order added. Perhaps only two desktop version can be on one chain. Perhaps desktop-beta, desktop-dev, desktop-rel all share the same settings database.

design featursync needs-more-info prioritP5

Source

brianddk

Most helpful comment

cc: @rossmoody Will need to account for cross-channel (e.g. Brave Beta macOS, Brave Dev on Windows) sync via detection and error dialog, since we're not supporting cross-channel sync. Primary use case is release channel sync across all platforms.

rebron on 21 Jun 2019

👍2

All 12 comments

Note... sync code which is obscured is NOT my actual sync code. It was just randomly generated for the screen shot.

brianddk on 1 Jun 2019

Reddit post of this issue

brianddk on 1 Jun 2019

rebron on 21 Jun 2019

👍2

@brianddk Are you still running into this issue? We were thinking maybe a firewall issue?

rebron on 21 Jun 2019

I can't verify, I had to remove Brave because of: https://github.com/brave/brave-browser/issues/4904 . I can go ahead and close since I no longer have a platform to test it on.

brianddk on 22 Jun 2019

@rebron I'm currently getting this issue. I enter my sync code, as provided from another computer that has all my bookmarks and, when I click "confirm sync code" nothing happens. This is on release channel.

tmanderson on 9 Dec 2019

I've got the same issue. Confirm sync code doesn't work when trying to come over from mobile. Funny as when I clicked setup Mobile it crashes the browser each time so desktop setup was the last option. Nailed it!

sparke16 on 24 Dec 2019

Hey there, same issue here. Clicking the Confirm Sync button has no effect. I am not coming from mobile but from my other Windows machine.

Version 1.2.42 Chromium: 79.0.3945.117 (Official Build) (64-bit)
Windows 10 Home 1809 OS Build 17763.914

palunel on 14 Jan 2020

👍1

I think i defeat it! Just try to enter incorrect words (i accidentally paste the combination twice) and hit Sync. Browser will show an error? than correct the combination and sync again.

Palik-ua on 14 Jan 2020

👍1

Same issue here, I have my laptop and my android device on a chain but when i try to add my desktop computer and click confirm it does nothing.
Brave Version 1.2.43 Chromium: 79.0.3945.130 (Official Build) (64-bit)
Windows 10 Pro

IgnacioMGarrido on 9 Feb 2020

Same issue here. I have my laptop and my android device on a chain. When I try my second laptop and click confirm it does nothing.
Brave Version 1.2.43 Chromium: 79.0.3945.130 (Official Build) (64-bit)
Debian 10

codesnippy on 9 Feb 2020

This does not work for me. I am on Pop_OS (Linux) trying to sync to iOS. Brave version is _1.12.112 Chromium: 84.0.4147.125 (Official Build) (64-bit)_