Brave-browser: Unable to open Ads from Notification center

Created on 15 Apr 2019  路  38Comments  路  Source: brave/brave-browser

Description


Unable to open Ads from Notification center

Steps to Reproduce

  1. Set Focus Assist settings to Alarm Only in Windows OS
  2. Clean profile 0.63.40
  3. Enable Rewards
  4. Open brave.com
  5. Verify that Ads notification is displayed under the notification center
  6. Click on the Ads notification

Actual result:


Clicking on the notifications within the notification slide, just dismisses the banner without opening brave or displaying the ad.

Ads

image (5)

Expected result:

The user should be able to open the Ads

Reproduces how often:

Always

Brave version (brave://version info)

Brave | 0.63.40 Chromium: 74.0.3729.61聽(Official Build)聽beta聽(64-bit)
-- | --
Revision | 5df2c8936783bd7575987e45d72a92fcf528496b-refs/branch-heads/3729@{#645}
OS | Windows聽10 OS Build 17134.523

Reproducible on current release: NA

  • Does it reproduce on brave-browser dev/beta builds? Yes

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional Information

The issue is reported by the community
https://community.brave.com/t/unable-to-open-ads-from-notification-area/49199/4

@brave/legacy_qa @tmancey

OWindows QA Pass-Win64 QYes bug featurads prioritP2 release-noteinclude
Source
picture GeetaSarvadnya
👍1

Most helpful comment

@jsecretan should we reprioritize this to maybe a P3? Seems like we're getting more +1 from Win users who are running into this. Imagine we'll want to get this fixed sooner than later.

picture kjozwiak on 28 May 2019
👍3

All 38 comments

https://bravesoftware.slack.com/archives/C43LW5U2H/p1555318060044600?thread_ts=1555302183.044200&cid=C43LW5U2H
Comments added in above slack thread:
using undocumented and unsupported methods it is possible to detect the status of Focus Assist.
@tmancey is investigating the issue.

GeetaSarvadnya picture GeetaSarvadnya on 15 Apr 2019

I'm running win10 x64, with Focus Assist set to Alarms Only, and am observing the notifications in the OS Notification Tray. 

Brave | 0.64.47 
Chromium: 74.0.3729.61聽(Official Build)聽dev聽(64-bit)
-- | --
Revision | 5df2c8936783bd7575987e45d72a92fcf528496b-refs/branch-heads/3729@{#645}
OS | Windows聽10 OS Build 17134.706

Including a screenshot to illustrate as well.
brave-sys-notifications-04162019-win10x64

lukemulks picture lukemulks on 16 Apr 2019

@lukemulks , yes, the notifications are collected in the notification tray. However, they cannot be opened. Clicking on them just dismisses them without showing any ad.

rivy picture rivy on 15 May 2019
👍2

+1 from Community too:
https://community.brave.com/t/notification-enabled-but-not-working/49594/63

Is there any particular reason we have this set to P4? Windows users are having enough trouble with ads/notifications as it is -- sucks to finally get them up and running only to not be able to view the ads. @rebron

Brave-Matt picture Brave-Matt on 17 May 2019
👍2

@Brave-Matt I didn't set priority for this issue. I'm guessing that focus assist setting isn't a default windows setting and therefore fewer users are affected. Looks like @tmancey is looking at it though.

rebron picture rebron on 18 May 2019

Notably, the ad notification will many times not open when the notification is clicked from the action center, even if "Focus Assist" is not enabled. Clicking on the floating ad works correctly, but once that panel is gone, it seems that clicking on the ad notification from within the action center slide out is generally borked.

Steps to reproduce (with default ad center settings, no focus assist)...

  1. wait for an ad notification panel
  2. click on the action center icon causing it to slide out

    • if the ad panel within the action center is clicked at this point, it does activate the browser ad process

  3. click outside of the action
  4. re-open the notification center and click on the ad panel

    • the ad panel closes without triggering the browser

rivy picture rivy on 18 May 2019

A few users in Community troubleshooting thread reporting this as well:
https://community.brave.com/t/brave-ads-windows-10-troubleshooting/56730/13

Brave-Matt picture Brave-Matt on 18 May 2019
👍2

@jsecretan should we reprioritize this to maybe a P3? Seems like we're getting more +1 from Win users who are running into this. Imagine we'll want to get this fixed sooner than later.

kjozwiak picture kjozwiak on 28 May 2019
👍3

i've been wondering about this since installing Brave almost a week ago or so. apparently i've missed out on about 330 ads so far, and i couldn't figure out why until i finally opened the notification center (which i basically never use) and saw all the ads, started clicking on them, and nothing happened.

alefnull picture alefnull on 1 Jun 2019

@alefnull @kjozwiak @jsecretan We have identified an issue where if an Ad notification is shown and the user quits the browser, Ads will no longer open when clicked. We are working on a fix for this issue and investigating the steps reproduced by @rivy. @alefnull did you quit the browser?

tmancey picture tmancey on 4 Jun 2019

@tmancey i actually rarely close my browser, and most of the times that i've clicked on the notifications in the notification center, my browser has been open, and nothing would happen. however, since posting my last comment, the few that i've clicked have actually opened successfully. so i'm not sure what happened, as i haven't done anything differently on my end, but it does appear to be working for me now.

alefnull picture alefnull on 5 Jun 2019

@alefnull Thank you for the update

tmancey picture tmancey on 7 Jun 2019

User also reported clicking on arrow thinking it would open up the ad when instead it closed the ad. This is confusing UI/UX, investigate further and discuss with UX

tmancey picture tmancey on 16 Jul 2019

Clicking the arrow to initiate "move to the notification center" is normal.

In my experience, the usual windows notification idiom with most applications is to click on the message box to open the notification or click the arrow to dismiss it to the notification center. Clicking the upper right 'X' within the notification center should completely dismiss the notification, deleting it.

All of that is working correctly.

But, when in the notification center, clicking the notification doesn't open Brave and display the ad if the ad moved directly to the notification center by "focus assist" or by clicking the arrow on the desktop panel notice to move it into the center. That's the problem this issue points out.

rivy picture rivy on 16 Jul 2019

@rivy thank you, much appreciated

tmancey picture tmancey on 16 Jul 2019

For the last few weeks, I don't remember seeing any ads at all while in "focused" mode. I hope that's not the way you are going with this... I'd like to have the ads but see them at my desired times.

IMO, they should just be like normal notifications and pull up the ad in-browser whenever clicked upon.

rivy picture rivy on 20 Sep 2019

+1 https://community.brave.com/t/brave-supported-ads-on-windows-10-not-opening/84464/2

Brave-Matt picture Brave-Matt on 24 Sep 2019

Fixed by https://github.com/brave/brave-core/pull/3084

tmancey picture tmancey on 23 Nov 2019

What revision will this go out in?

My current version updated last night and this is still broken.

rivy picture rivy on 23 Nov 2019

@rivy This fix is currently only in 1.3, are you able to test 1.3 (currently Nightly build), please? Thanks

tmancey picture tmancey on 25 Nov 2019

give me link download

0.63.40 Chromium: 74.0.3729.61聽(Official Build)聽beta聽(64-bit)

riswyre picture riswyre on 29 Nov 2019

@riswyre @rivy https://brave.com/download-nightly/

tmancey picture tmancey on 29 Nov 2019

but no ads Version 1.3.39 Chromium: 78.0.3904.108 (Official Build) nightly (32-bit)

riswyre picture riswyre on 29 Nov 2019

but no ads Version 1.3.39 Chromium: 78.0.3904.108 (Official Build) nightly (32-bit)

I have just updated here and I have updated to 1.3.39. Can you please explain "but no ads"? Thanks

tmancey picture tmancey on 29 Nov 2019

win 10 enterprise ltsc version 1809 32 bit

riswyre picture riswyre on 29 Nov 2019

@riswyre Do you have group policies etc. setup to block Windows native notifications? Do you have Focus Assist enabled?

tmancey picture tmancey on 29 Nov 2019

I've just downloaded dev v1.3.57.
I'll let you know how well it works in the next few days.

rivy picture rivy on 5 Dec 2019

After a few hours, I'm seeing no ads. 鈽癸笍

rivy picture rivy on 6 Dec 2019

@tmancey ,

Not fixed...
No ads being displayed...

rivy picture rivy on 7 Dec 2019

@tmancey ,

Please re-open this ... it's not fixed.

Further testing...

  • No ads at all with either "Focus Assist" on as either "Priority Only" or "Alarms Only".
  • Ads appear and do not collapse with "Focus Assist" off.
  • And when collapsed to the notification area using the upper right arrow, they appear in the notification area but do not open an ad in brave when clicked.

The desirable behavior is ...

  1. With "Focus Assist" off, Ads should appear and collapse to the notification center within a reasonably short time frame (a few seconds, preferably user determined) ... not working.
  2. If the upper right arrow of a displayed ad notice is clicked, the ad should immediately move to the notification area ... works.
  3. Within the notification area, the ad should be clickable causing brave to display the ad (opening the application if necessary) ... not working.
  4. With "Focus Assist" enabled (as either "Priority Only" or "Alarms Only", the ad should immediately load within the notification area and be clickable to open as above ... not working.
rivy picture rivy on 8 Dec 2019

@tmancey , this isn't fixed.

cc: @Brave-Matt , @GeetaSarvadnya , @jsecretan , @kjozwiak

rivy picture rivy on 13 Dec 2019

@rivy I will update you early next, as will discuss internally. Thank you for the above testing and input. Much appreciated. Terry

tmancey picture tmancey on 14 Dec 2019
👍1

Added OS/Windows label.

btlechowski picture btlechowski on 4 Jan 2020

@tmancey , Checking back in ... are you planning to re-open this?

rivy picture rivy on 21 Jan 2020

@tmancey Issue is still not fixed. I am not getting any ads when Focus Assist is set to Alarm Only - Ads are not popping up or being displayed under the notification center. Let me know if I am missing anything otherwise, I will log a follow-up issue for it.

GeetaSarvadnya picture GeetaSarvadnya on 22 Jan 2020
👍1

As discussed with @tmancey over the slack - there is a change in the behavior as we no longer show ads if notification are not enabled. Also, we won't get any ads when Focus Assist is set to Alarm Only
The detailed test plan is provided in the PR - https://github.com/brave/brave-core/pull/3084

GeetaSarvadnya picture GeetaSarvadnya on 23 Jan 2020
👎1

Too bad, that's unfriendly behavior for a lot of early adopters and advocates.
But it's your circus.

rivy picture rivy on 24 Jan 2020

Verification passed on

Brave | 1.3.100 Chromium: 79.0.3945.130聽(Official Build)聽beta聽(64-bit)
-- | --
Revision | e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS | Windows聽10 OS Version 1803 (Build 17134.1006)

Clean profile:

  • Ensured ad notifications are NOT shown on windows when Focus Assist is enabled
    [5016:6316:0124/124645.543:INFO:ads_impl.cc(1148)] Notification not made: Notifications not allowed
  • Ensured ad notification is shown when Focus Assist is disabled
    [4428:16072:0124/124905.285:INFO:ads_impl.cc(1305)] Ad notification shown:

Upgrade profile:
(Upgrade from 1.2.43 to 1.3.100)

  • Viewed ads in 1.2.43 ads collected in the notification center when focus assist is enabled --> upgrade to 1.3.100 ads are not shown in 1.3.100, Verified notifications not allowed text message in logs
    [5652:4820:0124/145717.418:INFO:ads_impl.cc(1148)] Notification not made: Notifications not allowed
  • Verified ads are shown when focus assist is disabled in an upgraded profile.
    [9440:11284:0124/150629.389:INFO:ads_impl.cc(1305)] Ad notification shown:

Verification passed on

Brave | 1.3.100 Chromium: 79.0.3945.130聽(Official Build)聽beta聽(64-bit)
-- | --
Revision | e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS | Windows聽10 OS Version 1909

GeetaSarvadnya picture GeetaSarvadnya on 24 Jan 2020
👎1
Was this page helpful?
0 / 5 - 0 ratings

Related issues

lansana picture lansana  路  3Comments
simonhong picture simonhong  路  3Comments
pitsi picture pitsi  路  3Comments
qingxiang-jia picture qingxiang-jia  路  3Comments
bbondy picture bbondy  路  3Comments