Brave-browser: Uninstall doesn't provide prompt to delete profile folder

Created on 3 Apr 2019 · 10Comments · Source: brave/brave-browser

Description

Uninstall doesn't provide prompt to delete profile folder

Steps to Reproduce

Upgrade to 0.62.50
Go to apps settings and uninstall Brave
No option to remove profile data is shown during uninstall process

Actual result:

There is no prompt to remove profile folder. Just silently removes the install

Expected result:

Reproduces how often:

Easy

Brave version (brave://version info)

Brave | 0.62.50 Chromium: 73.0.3683.86 (Official Build) (64-bit)
-- | --
Revision | f9b0bec6063ea50ce2b71f5b9abbae7beee319a6-refs/branch-heads/3683@{#858}
OS | Windows 10 OS Build 17763.379

Reproducible on current release:

Does it reproduce on brave-browser dev/beta builds?

Website problems only:

Does the issue resolve itself when disabling Brave Shields?
Is the issue reproducible on the latest version of Chrome?

Additional Information

Reproduced by @kjozwiak and @rebron

OWindows QYes bug prioritP3 regression release-noteinclude

Source

srirambv

Most helpful comment

@kjozwiak As noted in https://github.com/brave/brave-browser/issues/3987#issuecomment-537997497 the profile was purged.

btlechowski on 10 Oct 2019

🎉1 👍1

All 10 comments

Yikes - I am curious when this regressed. Too bad the regression script I wrote doesn't do Windows (yet!)

@srirambv did this work on 0.61.52?

bsclifton on 3 Apr 2019

@bsclifton looks like it regressed in 0.62.50 Chromium: 73.0.3683.86. @srirambv checked 0.61.52 Chromium: 73.0.3683.86on the release call and confirmed that it was only happening in0.62.50 Chromium: 73.0.3683.86`. I went through a few previous versions, also confirmed that it's a new regression:

0.62.50 Chromium: 73.0.3683.86 - Reproduced
0.61.52 Chromium: 73.0.3683.86 - Couldn't reproduce
0.61.51 Chromium: 73.0.3683.75 - Couldn't reproduce
0.60.48 Chromium: 72.0.3626.121 - Couldn't reproduce

kjozwiak on 4 Apr 2019

@bsclifton yes it works on 0.61.52. Used it as the screenshot for the expected result. Brave version specifies 73.0.61.52

srirambv on 4 Apr 2019

@bsclifton @rebron regression range:

0.62.32 Chromium: 73.0.3683.75 - Reproduced
0.62.31 Chromium: 73.0.3683.75 - Couldn't reproduce

kjozwiak on 9 Apr 2019

We should probably try getting this into 64.x

@rebron @bsclifton

srirambv on 8 May 2019

@bsclifton as per requested via our weekly triage meeting on Friday, I tried the following with the latest nightly and can still reproduce the issue. Doesn't seem like CR75 resolved the issue. Build used:

Brave | 0.68.57 Chromium: 75.0.3770.90 (Official Build) nightly (64-bit)
--- | ---
Revision | a6dcaf7e3ec6f70a194cc25e8149475c6590e025-refs/branch-heads/3770@{#1003}
OS | Windows 10 OS Version 1809 (Build 17763.557)

kjozwiak on 18 Jun 2019

No longer reproduces on Windows 7 x64 and x86

Brave | 0.69.132 Chromium: 77.0.3865.90 (Official Build) (64-bit)
-- | --
Revision | 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS | Windows 7 Service Pack 1 (Build 7601.24494)

I also verified that the profile is purged.