Brave-browser: should be "Same as macOS" and not "Same as MacOS" under brave colors selection

[kjozwiak]

Description

The Brave colors selection under Appearances should be Same as macOS and not Same as MacOS. Apple uses macOS.

Steps to Reproduce

1. launch brave and visit brave://settings and look for Brave colors: under Appearances

Actual result:

Expected result:

Should be Same as macOS and NOT Same as MacOS

Reproduces how often:

100% reproducible using the above STR.

Brave version (brave://version info)

Brave | 0.63.14 Chromium: 73.0.3683.75 (Official Build) dev(64-bit)
-- | --
Revision | 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS | Mac OS X

Reproducible on current release:

N/A as this hasn't made it into release.

• Does it reproduce on brave-browser dev/beta builds?

Yes, reproducible under Nightly/Dev.

Website problems only:

• Does the issue resolve itself when disabling Brave Shields?
• Is the issue reproducible on the latest version of Chrome?

Additional Information

[rebron]

cc: @petemill there's this one and a few other text clean up ones, #2494 and location bar -> address bar.

[kjozwiak]

I was going to grab this one as it seems like an easy one to fix 👍 @petemill mind if I take this one and give it a go if you haven't started/completed the work?

[aqeelparpia]

Hello @kjozwiak @rebron
Could I please work on this ? I really want to contribute to this project.

[petemill]

Hi @aqeelparpia, this is a simple string change, but I'd be happy to help you contribute this change if you want to get used to the contribution process, if @kjozwiak doesn't have something in-progress.

You should be able to search for "Same as MacOS" in a code editor to find the file. It's in a .grd file.

[kjozwiak]

@aqeelparpia all yours :) Appreciate the contribution!

[aqeelparpia]

I'm having troubles setting up the project

[bsclifton]

@aqeelparpia what steps have you done so far? Do you have XCode and the command line tools installed? You should be able to follow the steps here:
https://github.com/brave/brave-browser/wiki/macOS-Development-Environment

[rebron]

Closing. Fixed with https://github.com/brave/brave-core/pull/1909

[LaurenWags]

@kjozwiak can you test this one since you have Mojave?

[simonhong]

@LaurenWags I tested this on from beta(0.65.x) to nightly (0.67.x) now and all are using correct string (macOS).

[kjozwiak]

Verification PASSED on macOS 10.14.4 x64 using the following build:

Brave | 0.65.98 Chromium: 74.0.3729.131 (Official Build) beta(64-bit)
-- | --
Revision | 518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS | Mac OS X

@LaurenWags looks good 👍

[LaurenWags]

Thanks @simonhong @kjozwiak for confirming 😄