Brave-browser: Brave shields popup can be opened in a new tab

[AnthonyLenglet]

Description

The brave shields popup can be opened in a new tab, which shouldn't be possible

Steps to Reproduce

1. Open the brave shield popup
2. Middle click the "global shield defaults" link in the popup

Actual result:

The popup is now opened in its own tab

Expected result:

Middle click shouldn't do anything

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave | 0.59.35 Chromium: 72.0.3626.81 (Official Build) (64-bit)
-- | --
Revision | ac8b982e05014492d1bd7d317628a4f22a97ffa0-refs/branch-heads/3626@{#796}
OS | Windows

Reproducible on current release:

• Does it reproduce on brave-browser dev/beta builds?

Website problems only:

• Does the issue resolve itself when disabling Brave Shields? No
• Is the issue reproducible on the latest version of Chrome? No

[srirambv]

Nice catch :+1:

[arsalankhalid]

Can I grab this?

[arsalankhalid]

@AnthonyLenglet are you performing the middle click through the track pad or mouse? Does it matter?

[AnthonyLenglet]

I'm doing it through a mouse, don't actually know if it should matter though (my guess would be that it doesn't, because its the shortcut to open a link in a new tab)

[bsclifton]

@arsalankhalid go for it 😄 Let us know if you need help

[meerasndr]

This seems solved?

[bsclifton]

Thanks for raising, @meerasndr - you're right, looks like it's resolved 😄 Closing