Brave-browser: Add a new setting that allows Brave Rewards icon to be hidden when inactive

[davidtemkin]

Test plan

See https://github.com/brave/brave-core/pull/1552

Description

Add a new on/off setting in the "Appearance" section, below "Use wide location bar", as follows:

"Hide Brave Rewards icon in location bar when Rewards is not enabled"

This option should default to off -- i.e., the default setting is that Brave Rewards icon is always visible, whether or not Rewards is active.

When the setting is on, the Brave Rewards icon should be hidden unless Rewards is on. If Rewards is on, the icon is visible regardless of the setting.

The setting only controls whether or not the icon is visible when Rewards is off.

[eljuno]

Related to #1475?

[davidtemkin]

Yes. This is how we are solving that issue.

[davidtemkin]

Updated the string in initial comment.

[rebron]

We could also do two lines:
"Show Brave Rewards button"
"Hide Brave Rewards button in address bar when Rewards is not enabled"

[davidtemkin]

If it were two lines the second line would need to be a more detailed explanation of the first line (in keeping with Chrome style):

First line: "Always show Brave Rewards icon in location bar"
Second line: "Shows Brave Rewards icon even when Rewards is not enabled"

That could work. Don't know if it's preferable.

(BTW if we want to use "address bar" , we should change existing references to "location bar" in settings)

[rebron]

I think the original language was right with a few updates using "button" and "address bar":

first line: Hide Brave Rewards button
second line: Hides Brave Rewards button in address bar when Rewards is not enabled

We'll change instances of location bar/url bar to address bar to be consistent.

[mkarolin]

@rebron How should Guest/Tor windows behave? There is no Appearance section in settings for those and, currently, the button is always disabled in them.

[tomlowenthal]

The BAT icon should never be shown in Guest windows.
For now, the icon should never be shown in private windows with Tor.

The setting's relationship to the icon should function the same way in private windows:

• If Brave Rewards _is not_ enabled AND the setting _is_: do not show the icon.
• If Brave Rewards is enabled OR the setting is disabled: show the disabled icon.

[btlechowski]

Verification passed on

Brave | 0.61.37 Chromium: 73.0.3683.39 (Official Build) beta (64-bit)
-- | --
Revision | cc53b0e12fcaf42e4bab8d6c23bd4fb7aae99f6c-refs/branch-heads/3683@{#413}
OS | Windows 7 Service Pack 1 Build 7601.24312

Used test plan from https://github.com/brave/brave-core/pull/1552

Verification passed on

Brave | 0.61.41 Chromium: 73.0.3683.39 (Official Build) beta (64-bit)
--- | ---
Revision | cc53b0e12fcaf42e4bab8d6c23bd4fb7aae99f6c-refs/branch-heads/3683@{#413}
OS | Linux mint

• Verified the test plan from https://github.com/brave/brave-core/pull/1552

Verification PASSED on macOS 10.14.3 x64 using the following build:

Brave | 0.61.45 Chromium: 73.0.3683.39 (Official Build) beta(64-bit)
-- | --
Revision | cc53b0e12fcaf42e4bab8d6c23bd4fb7aae99f6c-refs/branch-heads/3683@{#413}
OS | Mac OS X

• Went through the test plan outlined under https://github.com/brave/brave-core/pull/1552